After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723432 - Fixes for presence
Fixes for presence
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-01 20:10 UTC by Giovanni Campagna
Modified: 2014-02-07 10:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MainWindow: fix function call syntax (1.37 KB, patch)
2014-02-01 20:11 UTC, Giovanni Campagna 		committed Details | Review
Include a status when requesting offline presence (1.66 KB, patch)
2014-02-01 20:11 UTC, Giovanni Campagna 		committed Details | Review
AccountsMonitor: complete the async call to set the presence (1.11 KB, patch)
2014-02-01 20:11 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2014-02-01 20:10:58 UTC 
And some other stuff I spotted on the way.
Comment 1 Giovanni Campagna 2014-02-01 20:11:01 UTC 
Created attachment 267798 [details] [review]
MainWindow: fix function call syntax

These are not constructors.
Comment 2 Giovanni Campagna 2014-02-01 20:11:05 UTC 
Created attachment 267799 [details] [review]
Include a status when requesting offline presence

While this probably makes no difference for the IRC protocol,
it makes for a better output of mc-tool, and is consistent with
what empathy does.
Comment 3 Giovanni Campagna 2014-02-01 20:11:09 UTC 
Created attachment 267800 [details] [review]
AccountsMonitor: complete the async call to set the presence

It makes no difference because we ignore the result and we're
about to close the app anyway, but it's more correct in theory.
Comment 4 Florian Müllner 2014-02-06 18:36:16 UTC 
Review of attachment 267798 [details] [review]:

Whoops
Comment 5 Florian Müllner 2014-02-06 18:36:29 UTC 
Review of attachment 267799 [details] [review]:

OK
Comment 6 Florian Müllner 2014-02-06 18:36:40 UTC 
Review of attachment 267800 [details] [review]:

Sure.
Comment 7 Giovanni Campagna 2014-02-07 10:55:35 UTC 
Attachment 267798 [details] pushed as 703c4e8 - MainWindow: fix function call syntax
Attachment 267799 [details] pushed as dd4b257 - Include a status when requesting offline presence
Attachment 267800 [details] pushed as 6dd6383 - AccountsMonitor: complete the async call to set the presence