GNOME Bugzilla – Bug 722868
app menu: standardize Help/About/Quit
Last modified: 2014-01-24 03:09:42 UTC
Add a separatoe between the preferences menu and the about and quit menus. Also replace "About Sound Recorder" with "About". See https://wiki.gnome.org/Design/HIG/ApplicationMenus.
Created attachment 267085 [details] [review] App menu: standardize Preferences/About/Quit
(In reply to comment #1) > Created an attachment (id=267085) [details] [review] > App menu: standardize Preferences/About/Quit Thanks for the patch! "About <application name>" is actually pretty standard Documents and Weather both use it. Other than that the patch looks good. If you revert your change: - menu.append(_("About Sound Recorder"), 'app.about'); + menu.append_section(null, section); Then I'll test it out. Thanks again!
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=267085) [details] [review] [details] [review] > > App menu: standardize Preferences/About/Quit > > Thanks for the patch! "About <application name>" is actually pretty standard > Documents and Weather both use it. Other than that the patch looks good. If you > revert your change: > - menu.append(_("About Sound Recorder"), 'app.about'); Sorry! Wrong line. I mean that you need to revert just the change to the about item. + section.append(_("About"), 'app.about'); No problems with the + menu.append_section(null, section); line. > > Then I'll test it out. Thanks again!
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Created an attachment (id=267085) [details] [review] [details] [review] [details] [review] > > > App menu: standardize Preferences/About/Quit > > > > Thanks for the patch! "About <application name>" is actually pretty standard > > Documents and Weather both use it. Other than that the patch looks good. If you > > revert your change: > > - menu.append(_("About Sound Recorder"), 'app.about'); > Sorry! Wrong line. I mean that you need to revert just the change to the about > item. > + section.append(_("About"), 'app.about'); > > No problems with the > + menu.append_section(null, section); > line. > > > > Then I'll test it out. Thanks again! This isn't right. This changed in the last weeks. See https://git.gnome.org/browse/gnome-documents/commit/?id=1eb29d45f5556b26502059acc56e0e013da0bf4d and https://git.gnome.org/browse/gnome-weather/commit/?id=dfd4d85dc90b1556765f664d7ab6e8071e4ce077. You can to find the discuss about this in the desktop-list mailing list.
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > (In reply to comment #1) > > > > Created an attachment (id=267085) [details] [review] [details] [review] [details] [review] [details] [review] > > > > App menu: standardize Preferences/About/Quit > > > > > > Thanks for the patch! "About <application name>" is actually pretty standard > > > Documents and Weather both use it. Other than that the patch looks good. If you > > > revert your change: > > > - menu.append(_("About Sound Recorder"), 'app.about'); > > Sorry! Wrong line. I mean that you need to revert just the change to the about > > item. > > + section.append(_("About"), 'app.about'); > > > > No problems with the > > + menu.append_section(null, section); > > line. > > > > > > Then I'll test it out. Thanks again! > > This isn't right. > This changed in the last weeks. > See > https://git.gnome.org/browse/gnome-documents/commit/?id=1eb29d45f5556b26502059acc56e0e013da0bf4d > and > https://git.gnome.org/browse/gnome-weather/commit/?id=dfd4d85dc90b1556765f664d7ab6e8071e4ce077. > > You can to find the discuss about this in the desktop-list mailing list. I see! Thanks for the heads-up. I'll test the patch as is, then!
Review of attachment 267085 [details] [review]: Pushed as 3585eae - App menu: standardize Preferences/About/Quit