After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722840 - Crash _shell_app_remove_window()
Crash _shell_app_remove_window()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.11.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-23 15:46 UTC by Michael Catanzaro
Modified: 2014-01-23 17:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-shell backtrace (26.93 KB, text/plain)
2014-01-23 15:46 UTC, Michael Catanzaro 		  Details
shell-app: Unref running state when window count drops to zero (1.70 KB, patch)
2014-01-23 17:08 UTC, Florian Müllner 		committed Details | Review

Description Michael Catanzaro 2014-01-23 15:46:00 UTC 
Created attachment 267056 [details]
gnome-shell backtrace

I can consistently crash gnome-shell (built from git today) by crashing gnome-chess in the following way:

* Launch gnome-chess
* Click on Open as if to load a saved game
* Remove the filter for PGN files in the bottom right of the file chooser
* Select an image file instead of a PGN file and try to open it

This is a known bug in gnome-chess that I've been meaning to fix for ages. But this has never crashed gnome-shell before.
Comment 1 Florian Müllner 2014-01-23 17:08:21 UTC 
Created attachment 267064 [details] [review]
shell-app: Unref running state when window count drops to zero

With the lastest ShellApp changes, an app is considered stopped
when the last "interesting" window is closed. However the app
may still track non-interesting windows, so if we unref the
running state on the state transition, we hit an assertion later-on
when trying to remove the non-interesting window.
Fix this by keeping the running state around until the last window
is closed.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-01-23 17:40:10 UTC 
Review of attachment 267064 [details] [review]:

OK.
Comment 3 Florian Müllner 2014-01-23 17:46:04 UTC 
Attachment 267064 [details] pushed as 73f6e75 - shell-app: Unref running state when window count drops to zero