GNOME Bugzilla – Bug 722698
Crash creating a new folder
Last modified: 2014-12-01 15:13:30 UTC
To reproduce: - Open evolution - Go to mail view - Try to create a new folder Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00007fffdc9cc25c in folder_tree_maybe_expand_row (model=0x1674120, tree_path=0x150a4b0, iter=0x7fffffffd4d0, folder_tree=0x1682350) at em-folder-tree.c:545 545 u = g_hash_table_lookup (priv->select_uris_table, key); (gdb) bt
+ Trace 233062
From an IRC talk with Matthew Barnes: 12:28 <@ mbarnes> fidencio: looks like the signal IDs "loading_row_id" and "loaded_row_id" never get disconnected in EMFolderTree 12:28 <@ mbarnes> fidencio: which means the signals will fire after EMFolderTree is finalized 12:29 <@ mbarnes> "selection_changed_handler_id" too, for that matter
Created attachment 266876 [details] [review] Bug #722698 - Crash creating a new folder
You're disconnecting "loading_row_id" twice, but otherwise looks good.
Created attachment 266894 [details] [review] Bug #722698 - Crash creating a new folder
Attachment 266894 [details] pushed as 555912b - Bug #722698 - Crash creating a new folder
Review of attachment 266894 [details] [review]: Good to go.
It looks like this bug is present in the recently released Evolution 3.10.4. I've verified that the patch works on top of 3.10.4. Ok to push it to the gnome-3-10 branch?
Sure, although I don't know if we're doing another 3.10 release.
Ok, pushed to gnome-3-10 just in case. Might be useful even without release for distros cherry-picking fixes (or directly building from git stable branches).
*** Bug 667122 has been marked as a duplicate of this bug. ***
*** Bug 726074 has been marked as a duplicate of this bug. ***
*** Bug 726756 has been marked as a duplicate of this bug. ***
*** Bug 726839 has been marked as a duplicate of this bug. ***
Just as a note, we have applied this patch over the 3.10.4 build, but now every time I try to create a new folder the folder is created correctly but its displayed like it was a tree of folders. Of course clicking on the small triangle on the left side of the folder trying to expand the tree it does not expand nothing as there is only one folder and not a tree of them.
When you are talking about it, I see it too. I noticed it, but didn't know it was caused by this patch. I'd like to fix it soon.
I noticed it, because before without the patch it was crashing , but later when i applied the patch i tried that if it fixed it and noticed immediately this thing. Fix is very welcome also for a 3.10.x series.
The problem is not caused by a patch here, it is caused by this commit: https://git.gnome.org/browse/evolution/commit/?id=b0106cc8
I made changes on both evolution-data-server and evolution sides. It'll not fix everything, but the most cases and creation of folders under On This Computer it will. Backport of the patches to 3.10.4 might be simple. Created commit fbec8fe in eds master (3.13.1+) [1] Created commit 61695f0 in evo master (3.13.1+) [2] Created commit 5cc6ad8 in eds evolution-data-server-3-12 (3.12.2+) Created commit 2aae852 in evo evolution-3-12 (3.12.2+) [1] https://git.gnome.org/browse/evolution-data-server/commit/?id=fbec8fe [2] https://git.gnome.org/browse/evolution/commit/?id=61695f0
Created attachment 282422 [details] [review] 61695f0 to push to 3-10 fbec8fe cherry-picks cleanly 61695f0 requires a small adjustment - attached. Would you please push both to gnome-3-10?
(In reply to comment #18) > Would you please push both to gnome-3-10? I'm not a fan of applying changes to dead branches, I'm sorry. Distributions can find your change here.
*** Bug 735036 has been marked as a duplicate of this bug. ***