After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722396 - avimux: don't make the buffer writable unless absolutely necessary
avimux: don't make the buffer writable unless absolutely necessary
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-17 07:15 UTC by Michael Olbrich
Modified: 2014-01-17 22:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.24 KB, patch)
2014-01-17 07:15 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2014-01-17 07:15:32 UTC 
Created attachment 266527 [details] [review]
patch

When recording live streams, it it likely that the timestamp remains the same.
Making a buffer writable is usually quite cheap. However, if the buffer comes from a
hardware encoder, the memory may not be shareable and must be copied.
Comment 1 Thiago Sousa Santos 2014-01-17 22:55:22 UTC 
Thanks for your patch, it has been pushed to master.

commit 447556fe6bd109a3538d71420a24e6f55e647d4d
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Wed Dec 11 09:36:22 2013 +0100

    avimux: don't make the buffer writable unless absolutely necessary
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722396