After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722295 - keyfile should auto-detect connection type
keyfile should auto-detect connection type
Status: RESOLVED DUPLICATE of bug 696936
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-01-15 20:33 UTC by Dan Williams
Modified: 2015-02-18 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Dan Williams 2014-01-15 20:33:39 UTC 
Instead of requiring users to set 'type=xxx' in the [connection] block, the keyfile plugin should auto-detect that type based on what groups are available.  eg, if there is a [802-3-ethernet] block, then the connection will be type=802-3-ethernet.  And so on.

The only case where this is ambiguous is for pppoe connections, where for backwards compatibility, we allow type=pppoe and a wired setting might be present.

I think the keyfile plugin should always write out the type if it's updating the file, but I don't think users should have to set type manually if they are creating one from scratch.
Comment 1 Pavel Simerda 2014-01-16 09:09:35 UTC 
Sounds reasonable, I'm all for.
Comment 2 Thomas Haller 2015-02-18 10:43:33 UTC 
ah, this was actually done as part of bug 696936 and merged with commit http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=fdef81207f7158a9acbdf900c05367bb960e6533


Belatedly closing as a duplicate.

*** This bug has been marked as a duplicate of bug 696936 ***