After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722259 - audiobasesink: Add skew adjustment window property
audiobasesink: Add skew adjustment window property
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-15 12:12 UTC by Edward Hervey
Modified: 2018-11-03 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
audiobasesink: Add skew adjustment window property (9.81 KB, patch)
2014-01-15 12:12 UTC, Edward Hervey 		reviewed Details | Review

Description Edward Hervey 2014-01-15 12:12:41 UTC 
Most audio sink clock reporting are initially "wobbly" (they go slightly
faster/slower) but eventually cancel out (the sum of skew stabilizes).

In order to avoid correcting too aggressively for those "fake" skew distortions,
wait for a certain amount of time before doing skew adjustments.
Comment 1 Edward Hervey 2014-01-15 12:12:44 UTC 
Created attachment 266350 [details] [review]
audiobasesink: Add skew adjustment window property
Comment 2 Sebastian Dröge (slomo) 2014-12-22 10:07:46 UTC 
Comment on attachment 266350 [details] [review]
audiobasesink: Add skew adjustment window property

Seems to make sense, but maybe instead this should be based on the R² from gst_clock_add_observation()? Or be a minimum number of observations before we start doing something based on them?

Having the window still after the first adjustment does not seem very useful as we will have a big enough number of observations remembered to not have the wobbly behaviour you mention.
Comment 3 Sebastian Dröge (slomo) 2014-12-22 10:12:51 UTC 
The same change should also be in audiobasesrc for symmetry I guess
Comment 4 GStreamer system administrator 2018-11-03 11:27:57 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/103.