Created attachment 267901 [details] [review]
Use a GtkHeaderBar

This might not look good in Ubuntu yet, because they may not have updated their theme for header bars, and they're probably also not yet taking advantage of the new GTK+ settings that allow the desktop environment to control the presence and placement of maximize/minimize/close buttons. Fortunately, they're going to ship Nibbles 3.10 or 3.8 this cycle, so it's not going to be a problem.

We also need to mark this as completed on those two wiki pages above. I can do that if you don't want to.

Created attachment 267992 [details] [review]
Depend on GTK+ 3.10

For GtkHeaderBar

Created attachment 268234 [details] [review]
Use a GtkHeaderBar

Rebased

This is highly desirable for 3.12 -- can we get it in before feature freeze? That's supposed to start with 3.11.90, but we could do a 3.11.90.1 I guess.  Unconventional, but it's my fault for not mentioning this earlier.

I don't see why this would still be needed:
gtk_window_set_default_size (GTK_WINDOW (window), 800, 600);

Adding the GTkHeaderBar makes it look quite bad on Ubuntu... Does it seem more useful on another environment?  

If this is important to get in, feel free to commit, and I'll see about making a follow up .1 release.

(In reply to comment #5)
> I don't see why this would still be needed:
> gtk_window_set_default_size (GTK_WINDOW (window), 800, 600);

I don't know either; I think that was probably an accident. Good catch, thanks!

> Adding the GTkHeaderBar makes it look quite bad on Ubuntu... Does it seem more
> useful on another environment?

Yeah; all GNOME programs should use header bars as soon as possible.  Most of the games already do!  (We're probably supposed to change the preferences and scores dialogs as well, but I figure we can hold off a little bit on those.)

Asides from consistency with other GNOME apps, the header bar makes Nibbles look much better when it has to display a fallback application menu in environments that don't display the app menu: Xfce, Cinnamon, MATE, KDE, Windows... basically everything besides GNOME, Unity, and OS X. Without the header bar, a menu bar will be added just to display the app menu; with the header bar and GTK+ 3.12, it's added to a Nibbles button packed into the left of the header bar (by default; desktops can change this).

Ubuntu probably hasn't updated Ambience for GTK+ 3.10 yet. I figure they have to very soon, since they're shipping it in their LTS and they take LTS releases very seriously. Keep in mind they won't include Nibbles 3.12 until 13.10 anyway, which will be over a year since 3.10 was released with our first header bar usage, and will surely have GTK+ 3.12, by which time Unity should have learned how to use the new GTK+ settings that allow it to control the location of the maximize/minimize/close.

(This disconnect between upstream and downstream is not unusual with Ubuntu: Unity is really different from GNOME, and it naturally takes them a bit of time to adapt to major changes. I don't like the long delays, but they're reasonable.)

> If this is important to get in, feel free to commit, and I'll see about making
> a follow up .1 release.

OK, thanks and sorry for the mess-up!

Attachment 267992 [details] pushed as 621f93e - Depend on GTK+ 3.10
Attachment 268234 [details] pushed as f6f090f - Use a GtkHeaderBar

(In reply to comment #6)
> (In reply to comment #5)
> > I don't see why this would still be needed:
> > gtk_window_set_default_size (GTK_WINDOW (window), 800, 600);
> 
> I don't know either; I think that was probably an accident. Good catch, thanks!

I removed this change from the commit I pushed; I guess git bz didn't notice.

(In reply to comment #6)
> Keep in mind they won't include Nibbles 3.12 until 

*14.10

I'm still stuck in last year :(