After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722074 - Color problems in the statusbar with the dark variant of the Adwaita theme
Color problems in the statusbar with the dark variant of the Adwaita theme
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.12.x
Other Linux
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2014-01-13 04:28 UTC by Jean-François Fortin Tam
Modified: 2014-01-17 03:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (8.58 KB, image/png)
2014-01-13 04:28 UTC, Jean-François Fortin Tam
Details

Description Jean-François Fortin Tam 2014-01-13 04:28:34 UTC
Created attachment 266119 [details]
screenshot

If you use gnome-tweak-tool to flip on the global "prefer dark theme" option (since GNOME 3.8), you will see that gnumeric works well except in two areas, which are relatively minor:

- The statusbar message area is shown with a (hardcoded?) white background,
  with white text (probably derived from the dark theme)... so it can't be read
  (in the attached screenshot, you may be able to read "Somme = 7"
  if you zoom in or tilt your LCD screen)

- The "selected row/column" header text labels are a dark red (or pure red?),
  which is a bit hard to discern on the dark background.
  That one is not a huge deal though.
Comment 1 Andreas J. Guelzow 2014-01-13 07:41:45 UTC
Rather than the statusbar, I believe you are referring to the calculation cell in the bottom right corner. (The status bar is to its left.) The calculated value picks a number format from the sheet selection. So the result could have a colour attached to it. As a consequence there is some strange interactions between weird theme colours and the text in that box.
Comment 2 Jean-François Fortin Tam 2014-01-13 15:54:03 UTC
This is probably a naïve question, but from a user's point of view it seems the displayed content is always just a text string... why not use a GtkLabel (maybe with a gtkmenubutton on the side to make the context menu's existence obvious)?
Comment 3 Andreas J. Guelzow 2014-01-13 15:59:00 UTC
Users reasonable expect to see the same format as on the sheet. So negative financial values may be in red while positive ones are in black.
Comment 4 Morten Welinder 2014-01-13 17:28:15 UTC
Re "red", see
https://git.gnome.org/browse/gnumeric/tree/src/gnumeric.css#n100
You can override that with css in ~/.config/gtk-3.0/gtk.css

The theming problems you see is a result of gtk+ effectively having stopped
supporting widgets other than (1) gtk+'s own set and (2) composite widgets
of (1) and (2).  The design is broken because every theme must be changed
for every application that uses custom widgets.
Comment 5 Morten Welinder 2014-01-13 17:34:47 UTC
Note, that without text colour in the calculation cell you cannot tell the
difference between -100 and +100 in cells that are formatted to accounting
format.  That'a a bit of a bummer!

We actually have code to change user-set colours in such a way that we don't
get white-on-white.  It wouldn't be unreasonable to have that work in this
case too.  Unfortunately I don't have any "prefer dark theme" option in my
setup.
Comment 6 Jean-François Fortin Tam 2014-01-14 02:45:41 UTC
> Unfortunately I don't have any "prefer dark theme" option in my setup.

Yeah unfortunately that only came with gnome 3.6 or newer (IIRC) (though you can temporarily set GtkSettings' "gtk-application-prefer-dark-theme" property to TRUE in your build of gnumeric if you really want to try it out only for gnumeric instead of the whole desktop)
Comment 7 Morten Welinder 2014-01-14 03:50:20 UTC
I was ahead of myself, it seems.  You can change the colour of that area:

GtkBin.auto-expr {
  background-color: yellow;
}
Comment 8 Morten Welinder 2014-01-17 01:21:51 UTC
The black-on-black problem with the auto-expression has now been fixed.
The other problems are user-solvable with css.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 9 Jean-François Fortin Tam 2014-01-17 03:05:24 UTC
Did you mean "light gray on white"? :)
Comment 10 Morten Welinder 2014-01-17 03:27:40 UTC
No, I meant black on black.  Add this to your ~/.config/gtk-3.0/gtk.css
and you'll see:

GtkBin.auto-expr { background-color: black; }