After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721926 - TerraParser (lyric's plugin) is not fetching lyrics correctly
TerraParser (lyric's plugin) is not fetching lyrics correctly
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
2.97
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-10 11:38 UTC by Joca
Modified: 2016-05-29 09:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update TerraParser to match current layout (1.18 KB, patch)
2016-04-26 19:45 UTC, Gayan Weerakutti
none Details | Review
lyrics: update TerraParser to match current layout (1.31 KB, patch)
2016-05-16 11:55 UTC, Gayan Weerakutti
committed Details | Review

Description Joca 2014-01-10 11:38:15 UTC
When I request to see any song's lyrics (from TerraBrasil, it's the only source  selected on plugin's preferences) it doesn't download the full lyrics, but only part of it.

For example, I tried to read Led Zeppelin The Rover's lyrics on Rhythmbox and it displays this:         
"            
                
                    
                
            
            
                The Rover
            
            
                Led Zeppelin
            
        
        
I've been to london, seen seven wonders 
I know to trip is just to fall 
I used to rock it, sometimes I'd roll it 
I always knew what it was for

Esta letra foi disponibilizada pelo site
http://letras.terra.com.br"
But the full lyrics are: http://letras.mus.br/led-zeppelin/70555/

Probably the site source changed a little bit but not TerraParser.
Comment 1 Gayan Weerakutti 2016-04-26 19:45:21 UTC
Created attachment 326799 [details] [review]
Update TerraParser to match current layout
Comment 2 Gayan Weerakutti 2016-05-16 11:55:12 UTC
Created attachment 327971 [details] [review]
lyrics: update TerraParser to match current layout
Comment 3 Jonathan Matthew 2016-05-29 09:35:36 UTC
Review of attachment 327971 [details] [review]:

pushed as commit 842f1ec
Comment 4 Jonathan Matthew 2016-05-29 09:36:00 UTC
thanks for the patch, and sorry it took me so long to get around to looking at it properly.