After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721371 - qtif: fix fread() error check
qtif: fix fread() error check
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-03 01:54 UTC by Allison Karlitskaya (desrt)
Modified: 2014-01-03 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtif: fix fread() error check (1.08 KB, patch)
2014-01-03 01:54 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-01-03 01:54:35 UTC 
fread() doesn't return -1 on error, so don't check for < 0.
Comment 1 Allison Karlitskaya (desrt) 2014-01-03 01:54:36 UTC 
Created attachment 265198 [details] [review]
qtif: fix fread() error check
Comment 2 Matthias Clasen 2014-01-03 12:19:25 UTC 
Review of attachment 265198 [details] [review]:

sure
Comment 3 Allison Karlitskaya (desrt) 2014-01-03 14:34:52 UTC 
Attachment 265198 [details] pushed as 7eccf98 - qtif: fix fread() error check