After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721295 - Update and deprecate gi.overrides.keysyms
Update and deprecate gi.overrides.keysyms
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-01 00:23 UTC by Simon Feltman
Modified: 2014-08-06 04:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update and deprecate gi.overrides.keysyms (32.60 KB, patch)
2014-01-01 00:24 UTC, Simon Feltman 		none Details | Review

Description Simon Feltman 2014-01-01 00:23:47 UTC 
The keysyms module is a carryover from PyGTK that can be both dynamically generated and should also be deprecated. Almost all of the keysyms exist in the Gdk module brought in through introspection as Gdk.KEY_<name>

Also note that this module is only available in as gi.overrides.keysyms and not available through gi.repository, so it would be a bit strange if there was actual usage of it. I think importing that module could probably just give a hard runtime warning if imported.

pygtkcompat was already dynamically generating these, so we should just move that code into the keysyms module.

There were a few Armenian keys left in for compatibility as they don't seem to exist in Gdk any longer.

Furthermore, some of the values seem to have changed in newer versions of Gdk:

gi.overrides.keysyms.Armenian_accent == 0x14b0
Gdk.KEY_Armenian_accent == 0x100055b
Comment 1 Simon Feltman 2014-01-01 00:24:42 UTC 
Created attachment 265092 [details] [review]
Update and deprecate gi.overrides.keysyms

Replace manually assigned keysyms with a dynamically generated version
pulling names and values from Gdk via GI. Add a runtime warning when
this module is imported.
Comment 2 Simon Feltman 2014-08-06 04:40:53 UTC 
No point in keeping this legacy stuff around especially when it is most likely not used.

The following fix has been pushed:
5ca4d25 Update and deprecate gi.overrides.keysyms