After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721146 - Magnifier: Erratic behaviour focus-tracking 'push'
Magnifier: Erratic behaviour focus-tracking 'push'
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
3.10.x
Other Linux
: Normal major
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-28 02:04 UTC by Magdalen Berns (irc magpie)
Modified: 2014-11-24 17:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
change default focus-tracking key to proportional (1.03 KB, patch)
2013-12-28 02:14 UTC, Magdalen Berns (irc magpie) 		needs-work Details | Review
Change default tracking key to 'proportional' (1.33 KB, patch)
2014-11-07 17:39 UTC, Magdalen Berns (irc magpie) 		accepted-commit_now Details | Review

Description Magdalen Berns (irc magpie) 2013-12-28 02:04:33 UTC 
Please see bugs

https://bugzilla.gnome.org/show_bug.cgi?id=720951

https://bugzilla.gnome.org/show_bug.cgi?id=707855

for background. To summarise, view seems to flip/toggle for focus-tracking when 'push' is selected:

Changing default to 'proportional' seems to avoid issue though would not be a fix for 'push' issues described by itself, I think it is a good idea to change the default so that the 'push' issue is not a problem when the magnifier is activated with its focus-tracking.
Comment 1 Magdalen Berns (irc magpie) 2013-12-28 02:14:03 UTC 
Created attachment 264951 [details] [review]
change default focus-tracking key to proportional
Comment 2 Bastien Nocera 2014-01-08 13:14:01 UTC 
Review of attachment 264951 [details] [review]:

The rationale for the change isn't included in the commit message.
Comment 3 Magdalen Berns (irc magpie) 2014-01-09 20:07:42 UTC 
(In reply to comment #2)
> Review of attachment 264951 [details] [review]:
> 
> The rationale for the change isn't included in the commit message.

Hi thanks for the review. What would you like to see explained in there? Is inserting 'view seems to flip/toggle for focus-tracking when
'push' is selected' enough? Or are you wanting details about the way the view is calculated and why a different approach would be preferable as a default option?
Comment 4 Bastien Nocera 2014-11-07 17:19:00 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Review of attachment 264951 [details] [review] [details]:
> > 
> > The rationale for the change isn't included in the commit message.
> 
> Hi thanks for the review. What would you like to see explained in there? Is
> inserting 'view seems to flip/toggle for focus-tracking when
> 'push' is selected' enough? Or are you wanting details about the way the view
> is calculated and why a different approach would be preferable as a default
> option?

I'd like an explanation that both me and users can parse. Because though I know a little about the magnifier, I have no idea what the vocabulary associated with it is.
Comment 5 Bastien Nocera 2014-11-07 17:20:39 UTC 
This is especially important as such a change would need to be mentioned in the release notes.
Comment 6 Magdalen Berns (irc magpie) 2014-11-07 17:39:28 UTC 
Created attachment 290198 [details] [review]
Change default tracking key to 'proportional'

Ok, how's that?
Comment 7 Bastien Nocera 2014-11-24 17:43:10 UTC 
Review of attachment 290198 [details] [review]:

Sure.
Comment 8 Magdalen Berns (irc magpie) 2014-11-24 17:54:02 UTC 
(In reply to comment #7)
> Review of attachment 290198 [details] [review]:
> 
> Sure.

Great, thanks. Committed now. :-)