After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721106 - Wrong symbols on season tiles in several tile sets
Wrong symbols on season tiles in several tile sets
Status: RESOLVED FIXED
Product: gnome-mahjongg
Classification: Applications
Component: general
git master
Other All
: Normal minor
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks: 664984
 
 
Reported: 2013-12-27 00:45 UTC by Sune M
Modified: 2013-12-29 02:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Quick gimp-edit of smooth.png as temporary workaround. (329.51 KB, image/png)
2013-12-27 23:35 UTC, Sune M
  Details
Remove some older tilesets (605.22 KB, patch)
2013-12-29 02:29 UTC, Michael Catanzaro
committed Details | Review
Fix blue flower tiles in smooth tile set (837.72 KB, patch)
2013-12-29 02:29 UTC, Michael Catanzaro
committed Details | Review

Description Sune M 2013-12-27 00:45:51 UTC
The season tiles (last four tiles) have wrong chinese symbols in these tile sets:

default.png
default2.png
seta.png
smooth.png

Right now the season tiles just have the chinese symbols for east, south, west and north (although in a different font than the wind tiles).

One would expect them to have the symbols for the seasons:

    Spring 春 chūn
    Summer 夏 xià
    Autumn 秋 qiū
    Winter 冬 dōng

as listed on the wikipedia page for Mah-jong tiles (http://en.wikipedia.org/wiki/Mahjong_tiles#Flower_tiles).
Comment 1 Michael Catanzaro 2013-12-27 14:18:25 UTC
Thanks for the detailed bug report.

A lot of those tile sets are very old and will probably be removed in the near future.  The smooth tile set is a bit nicer, though, and might be worth keeping and fixing. For any artists reading this bug: the default tile set is actually the one named postmodern, which is not affected; the ones named default are both old.
Comment 2 Sune M 2013-12-27 23:35:28 UTC
Created attachment 264948 [details]
Quick gimp-edit of smooth.png as temporary workaround.

I agree the smooth tile set is worth keeping and fixing - it's actually the one I prefer.

As a quick workaround until a real artist have a go at it I put this together in gimp. So anyone (who are as obsessed with details as I am) can replace the smooth.png until a real fix is released.
Comment 3 Michael Catanzaro 2013-12-28 01:51:25 UTC
I'm all for including that as-is, if you don't mind: it looks more than good enough to me.

Now, here's another concern I just noticed: those tiles are not treated as separate. All of your new flower tiles can be matched with each other and are all equivalent to the winter tile in the postmodern set, and the existing yellow flower tiles are all equivalent to the spring tile in the postmodern set. But they're never matched with each other when asking for a hint. (Hope I got all that right: I'm not very familiar with Mahjong.)   Am I correct in saying that is not the expected behavior? If so, I'll make a separate bug for this.
Comment 4 Sune M 2013-12-28 20:10:24 UTC
Well - if it's good enough for you, I don't mind. Go ahead and include :)

Now, about the season tiles not being treated as separate. First of all judging from the tiles placement in smooth.png and postmodern.svg, I would expect the season tiles (with black symbols) in the smooth-set to correspond to the yellow-ish spring tiles in the postmodern-set, and the flower tiles (with yellow symbols) in the smooth-set to correspond to the blue-ish winter tiles in the postmodern-set.

I am not sure I understand the issue 100%, but here is what the expected behavior should be (as I understand it from the wikipedia-page - I'm no mahjong expert either):
The flower tiles consist of 8 tiles in 2 groups (4 in each) - the flower-group and the season-group. These 8 tiles are special, because there is only one of each - all other tiles have 4 occurrences.
 - The flower-group: blue winter motive in postmodern, yellow symbols in smooth
 - The season-group: yellow spring motive in postmodern, black symbols in smooth

A tile from the flower-group should only be matched with one of the other three tiles from the flower-group. A tile from the season-group should only be matched with one of the other three tiles from the season-group. These matches should happen both in the hint-system and in real play. If this is not what's going on I would say it's incorrect behavior.

Hope I'm making things clearer and not just adding to the confusion here.
Comment 5 Michael Catanzaro 2013-12-29 01:56:53 UTC
No, that made sense. I should have read the page closer.

I have (or am going to):

* Commit your modified smooth.png
* Remove the other buggy tile sets
* Create a documentation bug #721181: the user help should explain how the flower tiles work

I was also going to create a bug for the hint system issue, but I just didn't test hard enough: it actually does properly match flower tiles.

Thanks for your help!
Comment 6 Michael Catanzaro 2013-12-29 02:29:05 UTC
The following fixes have been pushed:
738e719 Remove some older tilesets
1d75f9e Fix blue flower tiles in smooth tile set
Comment 7 Michael Catanzaro 2013-12-29 02:29:12 UTC
Created attachment 264981 [details] [review]
Remove some older tilesets

These are old and outdated. Except for greek-letters, they also use
incorrect Chinese characters on the season tiles.
Comment 8 Michael Catanzaro 2013-12-29 02:29:21 UTC
Created attachment 264982 [details] [review]
Fix blue flower tiles in smooth tile set

These tiles were displaying incorrect Chinese characters. Thanks to Sune
M. for the contribution.