After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721030 - WebDAV: download_contacts() leaks
WebDAV: download_contacts() leaks
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
3.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2013-12-25 03:46 UTC by Michel Dänzer
Modified: 2014-02-04 18:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix resource leaks in download_contacts() (1.17 KB, patch)
2013-12-25 03:46 UTC, Michel Dänzer 		committed Details | Review

Description Michel Dänzer 2013-12-25 03:46:32 UTC 
Created attachment 264863 [details] [review]
Fix resource leaks in download_contacts()

I tracked down a couple of leaks in download_contacts() with valgrind. With the attached patch, the evolution-addressbook-factory process memory usage is stable for me.
Comment 1 Michel Dänzer 2014-01-15 02:14:13 UTC 
Ping? These leaked hundreds of MBs per day for me...
Comment 2 Milan Crha 2014-02-04 18:35:07 UTC 
Review of attachment 264863 [details] [review]:

Nice catches, I'm committing the patch to master and gnome-3-10. Thanks.
Comment 3 Milan Crha 2014-02-04 18:39:41 UTC 
Created commit 9cfc619 in eds master (3.11.90+) [1]
Created commit 17535c9 in eds gnome-3-10 (3.10.4+)

[1] https://git.gnome.org/browse/evolution-data-server/commit/?id=9cfc619