After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720820 - pkgconfig: .pc files contain wrong plugin directory
pkgconfig: .pc files contain wrong plugin directory
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 719412
 
 
Reported: 2013-12-20 13:20 UTC by Lionel Landwerlin
Modified: 2014-01-15 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pkgconfig: plugin dir should use PKG version not API version (4.24 KB, patch)
2013-12-20 13:21 UTC, Lionel Landwerlin
none Details | Review

Description Lionel Landwerlin 2013-12-20 13:20:56 UTC
It seems the plugin directory in generated .pc files do not point at the right directory.
Comment 1 Lionel Landwerlin 2013-12-20 13:21:24 UTC
Created attachment 264616 [details] [review]
pkgconfig: plugin dir should use PKG version not API version
Comment 2 Gwenole Beauchesne 2014-01-13 17:48:14 UTC
OK.
Comment 3 Gwenole Beauchesne 2014-01-15 10:15:39 UTC
BTW, I wonder if we shouldn't better use GST_PKG_VERSION to check for GST_PLUGIN_PATH_1_0 since they are correlated in the end. :)
Comment 4 Gwenole Beauchesne 2014-01-15 10:28:07 UTC
commit e66179dffbe4bc95adfba6ed7631c0357bb233ad
Author: Lionel Landwerlin <llandwerlin@gmail.com>
Date:   Fri Dec 20 12:05:42 2013 +0000

    pkgconfig: plugin dir should use PKG version not API version.
    
    Fix the pluginsdir and includedir variables in the generated pkgconfig
    (.pc) files. The location needs to be built with the PKG version in
    mind instead of the API version.
    
    While we are at it, also fix the PKG version for GStreamer >= 1.3.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720820
    
    [additional fixes for includedir and pkg requirements]
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>