After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720374 - Windows with shadows cannot be moved to the top of the screen on quartz
Windows with shadows cannot be moved to the top of the screen on quartz
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Quartz
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-quartz maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-12-13 04:35 UTC by Allison Karlitskaya (desrt)
Modified: 2014-01-06 20:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdk: add gdk_window_set_shadow_width() (8.92 KB, patch)
2013-12-13 04:35 UTC, Allison Karlitskaya (desrt)
committed Details | Review
quartz: implement gdk_window_set_shadow_width() (3.46 KB, patch)
2013-12-13 04:35 UTC, Allison Karlitskaya (desrt)
none Details | Review
quartz: implement gdk_window_set_shadow_width() (3.46 KB, patch)
2014-01-06 19:23 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2013-12-13 04:35:37 UTC
See patches.
Comment 1 Allison Karlitskaya (desrt) 2013-12-13 04:35:39 UTC
Created attachment 264112 [details] [review]
gdk: add gdk_window_set_shadow_width()

And deprecate the X11-specific version of it.

We call this new API _set_shadow_width() and not _set_frame_extents()
because we already have a gdk_window_get_frame_extents() with a
different meaning and different type of value.
Comment 2 Allison Karlitskaya (desrt) 2013-12-13 04:35:41 UTC
Created attachment 264113 [details] [review]
quartz: implement gdk_window_set_shadow_width()

Use the information to allow dragging windows all the way to the top of
the screen (ie: allow the top shadow to go under the menubar).
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-12-13 04:43:11 UTC
Review of attachment 264112 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-12-13 04:44:00 UTC
Review of attachment 264113 [details] [review]:

I'll let the Quartz guys determine what to do about this... one nit:

::: gdk/quartz/gdkwindow-quartz.c
@@ +2908,3 @@
+
+
+

What's with all the whitespace?
Comment 5 Allison Karlitskaya (desrt) 2013-12-13 04:51:40 UTC
Review of attachment 264113 [details] [review]:

::: gdk/quartz/gdkwindow-quartz.c
@@ +2908,3 @@
+
+
+

I don't know :)
Comment 6 Allison Karlitskaya (desrt) 2013-12-13 04:54:13 UTC
Comment on attachment 264112 [details] [review]
gdk: add gdk_window_set_shadow_width()

Attachment 264112 [details] pushed as 04897e5 - gdk: add gdk_window_set_shadow_width()
Comment 7 Allison Karlitskaya (desrt) 2014-01-06 19:23:14 UTC
Created attachment 265469 [details] [review]
quartz: implement gdk_window_set_shadow_width()

Use the information to allow dragging windows all the way to the top of
the screen (ie: allow the top shadow to go under the menubar).
Comment 8 Allison Karlitskaya (desrt) 2014-01-06 20:27:52 UTC
Attachment 265469 [details] pushed as feedf46 - quartz: implement gdk_window_set_shadow_width()