GNOME Bugzilla – Bug 720215
sdp: parse encryption key field
Last modified: 2013-12-17 21:33:48 UTC
SDP library supports the SDP encryption key field. However, parsing is not implemented. RFC 4566 does not recommend the use of this field, but it hsould be parsed anyways.
Created attachment 263947 [details] [review] parse encryption key field
Olivier, you might want to push this change now. Does this handle k=clear:XXX, k=base64:XXX and k=uri:XXX properly? If I understand the code correctly it skips until the : and only uses what comes afterwards as key, thus dropping any information about how to interpret the key.
(In reply to comment #2) > Olivier, you might want to push this change now. Does this handle k=clear:XXX, > k=base64:XXX and k=uri:XXX properly? If I understand the code correctly it > skips until the : and only uses what comes afterwards as key, thus dropping any > information about how to interpret the key. read_string_del (str, sizeof (str), ':', &p); str will contain the first part before the delimiter and p will contain the second part. so, we have both the method and the key. read_string_del stores characters in str until the delimiter is found and return the pointer to the first character after the delimiter.
Ah right, I missed that str is also used later, not only p :) Nevermind then
Committed commit 7a7ae7d5f4e709e45596a11402e0356522262045 Author: Aleix Conchillo Flaqué <aleix@oblong.com> Date: Tue Dec 10 13:54:28 2013 -0800 sdp: parse encryption key field * gst-libs/gst/sdp/gstsdpmessage.c: parse encryption key field (k). https://bugzilla.gnome.org/show_bug.cgi?id=720215