After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720207 - don't use non-standard 'd' suffix on float literal
don't use non-standard 'd' suffix on float literal
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-10 18:07 UTC by Allison Karlitskaya (desrt)
Modified: 2013-12-10 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
don't use non-standard 'd' suffix on float literal (1.36 KB, patch)
2013-12-10 18:07 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2013-12-10 18:07:37 UTC 
See patch.
Comment 1 Allison Karlitskaya (desrt) 2013-12-10 18:07:38 UTC 
Created attachment 263938 [details] [review]
don't use non-standard 'd' suffix on float literal

C does not define the 'd' suffix for floating point literals.  In fact,
'double' is the default type of literals if not modified by 'f' (float)
or 'l' (long float).

Additionally: 'float' arguments are automatically upcasted to 'double'
when passing through a varargs list, so this wouldn't be needed in any
case.

This problem was causing failures to build with clang.
Comment 2 Giovanni Campagna 2013-12-10 18:11:02 UTC 
Review of attachment 263938 [details] [review]:

Looks good. I don't know where that d came from.
Comment 3 Allison Karlitskaya (desrt) 2013-12-10 18:48:15 UTC 
Attachment 263938 [details] pushed as b536449 - don't use non-standard 'd' suffix on float literal