After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720199 - basesrc: DTS becomes 0 in gst_base_src_do_sync() for first buffer
basesrc: DTS becomes 0 in gst_base_src_do_sync() for first buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-10 15:41 UTC by David Svensson Fors
Modified: 2013-12-17 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
basesrc: use segment start if DTS for first buffer is unset (887 bytes, patch)
2013-12-10 15:41 UTC, David Svensson Fors
committed Details | Review

Description David Svensson Fors 2013-12-10 15:41:45 UTC
Created attachment 263926 [details] [review]
basesrc: use segment start if DTS for first buffer is unset

We run into a problem with a small audio pipeline with one src and one sink. The first buffer is dropped by the sink, because the src sets its DTS to 0 in gst_base_src_do_sync(), and that is outside of the segment.

The attached patch is a suggested fix that solves the problem in our case. It sets DTS to segment start instead of 0, if DTS is unset for the first buffer in gst_base_src_do_sync().

It would be nice with feedback on whether this is the correct thing to do in general.

Part of the background is that we use timestamps that don't start on zero, which is why the DTS of zero ends up outside of the segment. (These timestamps originate from alsasrc, monotonic clock).
Comment 1 Sebastian Dröge (slomo) 2013-12-17 09:49:34 UTC
commit 892d36211fac3a2c663d9a1198c8a75a2dc3645e
Author: David Svensson Fors <davidsf@axis.com>
Date:   Tue Dec 10 15:53:54 2013 +0100

    basesrc: use segment start if DTS for first buffer is unset
    
    https://bugzilla.gnome.org/show_bug.cgi?id=720199