GNOME Bugzilla – Bug 720188
Panel is too wide
Last modified: 2014-03-03 11:06:05 UTC
Created attachment 263911 [details] screenshot See screenshot Using continuous
This is fallout from the change where we now give windows their natural size or the screen size and no longer their minimum size or 640px. Unfortunately, wrapping labels prefer to not be wrapped and will therefore request the full text's width as the natural size. So if you have a label that says "Adding an account allows your application to access it for documents, mail, contacts, calendar, chat and more" for the case where no account exists and that label is still used for size computation of a GtkStack - that currently shows configuration options for the current account - than that stack will request a rather large natural size. And that is why this dialog is so wide.
Created attachment 270699 [details] [review] online-accounts: Set max width in chars for label Set a limit of 40 chars to the label explaining the accounts panel when no accounts have been added yet. This prevents the label from expanding itself and the whole window arbitrarily.
Review of attachment 270699 [details] [review]: Looks good. Thanks for the patch. ::: panels/online-accounts/online-accounts.ui @@ +147,3 @@ <property name="justify">center</property> <property name="wrap">True</property> + <property name="max_width_chars">40</property> I swear I had tried this when the bug was first reported, and it still turned out wide. Maybe I was stupid.