After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720155 - media: add setup_sdp vmethod
media: add setup_sdp vmethod
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-09 23:35 UTC by Aleix Conchillo Flaqué
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media: add setup_sdp vmethod (21.68 KB, patch)
2013-12-09 23:40 UTC, Aleix Conchillo Flaqué 		reviewed Details | Review

Description Aleix Conchillo Flaqué 2013-12-09 23:35:18 UTC 
Currently, rtsp client can create a new SDP message and calls gst_rtsp_sdp_from_media. It would be good if media had a vmethod to setup the SDP message instead.
Comment 1 Aleix Conchillo Flaqué 2013-12-09 23:40:33 UTC 
Created attachment 263873 [details] [review]
media: add setup_sdp vmethod

Added setup_sdp vmethod plus gst_rtsp_media_setup_sdp. A user that subclasses rtsp media can now update the SDP more easily.
Comment 2 Sebastian Dröge (slomo) 2013-12-17 09:57:21 UTC 
Comment on attachment 263873 [details] [review]
media: add setup_sdp vmethod

Looks good to me and the API makes sense to me, but I'll let Wim decide if this is the API he wants for gst-rtsp-server.
Comment 3 Wim Taymans 2013-12-18 15:41:25 UTC 
Commited but left the actual code in rtsp-sdp.c. I imagine a future where we can also create other formats to descrie the media and I would like t keep that separate for now. It's all a bit hardcoded and inflexible for now but I think it will do for now.


commit baa0eadc5d0fcb0d1b2bcb9ab33fc08d0f7c88f8
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Wed Dec 18 16:37:27 2013 +0100

    media: add setup_sdp vmethod
    
    gst/rtsp-server/rtsp-media.[ch]: added setup_sdp vmethod and public
    gst_rtsp_media_setup_sdp.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=720155