GNOME Bugzilla – Bug 720099
codecparsers: h264: fix picture level scaling lists derivation from fall-back rule set B
Last modified: 2013-12-13 00:14:20 UTC
Hi, the following patch from Cong Zhong addresses the issue whereby incorrect scaling lists where provided to gst_h264_parser_parse_scaling_list() when we needed to apply the scaling list fall-back rule set B as specified for picture level scaling lists (7.4.2.2). i.e. intra and inter scaling lists were swapped. This fixes FRExt/freh5.264 and most likely http://samples.mplayerhq.hu/Matroska/H264+EAC3.mkv
Created attachment 263808 [details] [review] codecparsers: h264: fix picture level scaling lists derivation I will push the following patch once we complete full regression testing. I am also considering backports to 1.0 and 1.2 branches.
No regression observed on 4 platforms. Pushed to git master branch only at this time. I don't mind for gstreamer-vaapi, since I use built-in codecparsers from git master, but others would probably be interested in those changes for earlier versions too. If we are OK to backport this patch, then I'd also expect those from bug #708629 to get in as well for consistency, but that's not mandatory, they fix different bugs. :)
commit 631d5d94ed404afa04c5e62dc105d4798166e09f Author: Cong Zhong <congx.zhong@intel.com> Date: Wed Apr 17 10:44:48 2013 +0800 codecparsers: h264: fix picture level scaling lists derivation (rule B). Fix picture level scaling lists derivation from fall-back rule set B, as specified in 7.4.2.2. More precisely, the sequence level scaling lists need to be used but intra and inter lists arguments were swapped. This fixes FRExt/freh5.264 from conformance testing. https://bugzilla.gnome.org/show_bug.cgi?id=720099 Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Picked into 1.2. (The other one involves new API, so skipping that for now)