After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719965 - Let remote search providers not provide an icon
Let remote search providers not provide an icon
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: search
3.10.x
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-12-06 11:54 UTC by Debarshi Ray
Modified: 2013-12-10 16:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remoteSearch: Let remote search providers not provide an icon (1.38 KB, patch)
2013-12-06 12:00 UTC, Debarshi Ray 		reviewed Details | Review
remoteSearch: Let remote search providers not provide an icon (1.38 KB, patch)
2013-12-10 14:34 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-12-06 11:54:47 UTC 
While trying to add a search provider for gnome-terminal, I was not sure whether it makes more sense to offer a (relatively tiny) icon for each result as compared to using the extra space for showing more text. That is when I realized that the icon is not really optional.

The documentation in data/org.gnome.ShellSearchProvider2.xml says:
"Optionally, 'icon' (a serialized GIcon as obtained by g_icon_serialize) can be specified ..."
Comment 1 Debarshi Ray 2013-12-06 12:00:20 UTC 
Created attachment 263657 [details] [review]
remoteSearch: Let remote search providers not provide an icon

I do not know what I will end up doing in my search provider. Maybe I will offer an icon, after all. But at the moment, I found this useful to get things going.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-12-06 15:11:12 UTC 
Review of attachment 263657 [details] [review]:

::: js/ui/remoteSearch.js
@@ +209,3 @@
+            icon = new St.Icon({ gicon: gicon,
+                                 icon_size: size });
+        return icon

Missing semi.
Comment 3 Debarshi Ray 2013-12-10 14:34:47 UTC 
Created attachment 263918 [details] [review]
remoteSearch: Let remote search providers not provide an icon

Added the missing semi-colon. Sorry about that.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-12-10 15:41:47 UTC 
Review of attachment 263918 [details] [review]:

Yep.