After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719809 - gsignal: Signal connection ids are always > 0 if successful
gsignal: Signal connection ids are always > 0 if successful
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-12-03 22:19 UTC by Colin Walters
Modified: 2013-12-04 02:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gsignal: Signal connection ids are always > 0 if successful (3.18 KB, patch)
2013-12-03 22:20 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2013-12-03 22:19:54 UTC
Note this explicitly so that people can rely on doing:

if (mystruct->sigid > 0)
  g_signal_disconnect (mystruct->object, mystruct->sigid);
Comment 1 Colin Walters 2013-12-03 22:20:00 UTC
Created attachment 263455 [details] [review]
gsignal: Signal connection ids are always > 0 if successful
Comment 2 Allison Karlitskaya (desrt) 2013-12-03 22:28:50 UTC
Review of attachment 263455 [details] [review]:

Of course.  Thanks for the improvement.