GNOME Bugzilla – Bug 719789
mfcdec: should use video alignment
Last modified: 2014-10-31 07:44:13 UTC
Created attachment 263408 [details] [review] mfcdec: add support for GstVideoAlignment Currently the decoder changes the negotiate caps by setting the padded width and height into the config of the buffer pool. Instead it should set the config with the right video alignment and add the associated option. Note sure to do that the right way in the following patch so let me know :)
Review of attachment 263408 [details] [review]: Though I'm not fully convince we should merge this, as we'll probably remove that element when v4l2videodec is ready ::: sys/mfc/gstmfcdec.c @@ +1017,3 @@ + align.padding_top = self->crop_top; + align.padding_right = self->width - self->crop_width; + align.padding_bottom = self->height - self->crop_height; Leaving random value inside the stride[] array is not very nice
(In reply to comment #1) > Review of attachment 263408 [details] [review]: > > Though I'm not fully convince we should merge this, as we'll probably remove > that element when v4l2videodec is ready I'm curious, where does this v4l2videodec live? here??? http://cgit.collabora.com/git/user/nicolas/gst-plugins-good.git/log/?h=v4l2videodec
(In reply to comment #2) > I'm curious, where does this v4l2videodec live? > > here??? > http://cgit.collabora.com/git/user/nicolas/gst-plugins-good.git/log/?h=v4l2videodec Yes, but there is nothing to review for now, this is just a random snapshot of my daily work. Will have it's own bug when it's time.
mfcdec has been removed from gst-plugins-bad since integration of v4l2videodec in gst-plugins-good.