After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719567 - js: Use SOURCE_CONTINUE/SOURCE_REMOVE constants in source functions
js: Use SOURCE_CONTINUE/SOURCE_REMOVE constants in source functions
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-29 16:06 UTC by Florian Müllner
Modified: 2013-12-16 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
js: Use SOURCE_CONTINUE/SOURCE_REMOVE constants in source functions (29.50 KB, patch)
2013-11-29 16:06 UTC, Florian Müllner 		committed Details | Review
js: Use EVENT_PROPAGATE/EVENT_STOP constants in event handlers (46.03 KB, patch)
2013-11-29 19:02 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-11-29 16:06:02 UTC 
Minor cleanup to improve readability. Depends on bug 719566.
Comment 1 Florian Müllner 2013-11-29 16:06:06 UTC 
Created attachment 263143 [details] [review]
js: Use SOURCE_CONTINUE/SOURCE_REMOVE constants in source functions

With support for boolean constants in g-i, we can finally use the
more readable constants instead of true/false.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-11-29 17:24:03 UTC 
We should also probably do Clutter.EVENT_RETURN / Clutter.EVENT_CONTINUE while we're at it.
Comment 3 Florian Müllner 2013-11-29 19:02:23 UTC 
Created attachment 263157 [details] [review]
js: Use EVENT_PROPAGATE/EVENT_STOP constants in event handlers

Just as SOURCE_CONTINUE/SOURCE_REMOVE in source functions, these
constants increase code clarity over plain true/false.
Comment 4 Florian Müllner 2013-12-16 17:30:07 UTC 
Attachment 263143 [details] pushed as 751a3f0 - js: Use SOURCE_CONTINUE/SOURCE_REMOVE constants in source functions
Attachment 263157 [details] pushed as deb2f30 - js: Use EVENT_PROPAGATE/EVENT_STOP constants in event handlers