After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719509 - openoffice-read.c:4162: possible bad if test ?
openoffice-read.c:4162: possible bad if test ?
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
1.12.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-11-28 19:23 UTC by dcb
Modified: 2013-11-29 03:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description dcb 2013-11-28 19:23:21 UTC 
Source code is

   else if ( n_dots2 == 1 && n_dots2 == 1) {

I think probably

   else if ( n_dots1 == 1 && n_dots2 == 1) {

was intended. This bug found by static analysis checker, cppcheck.

[openoffice-read.c:4162] -> [openoffice-read.c:4162]: (style) Same expression on both sides of '&&'.
Comment 1 Andreas J. Guelzow 2013-11-29 03:27:53 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.