After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719460 - value argument to GtkTreeModelFilterModifyFunc needs "out" annotation
value argument to GtkTreeModelFilterModifyFunc needs "out" annotation
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkTreeView
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtktreeview-bugs
gtktreeview-bugs
Depends on:
Blocks:
 
 
Reported: 2013-11-28 04:07 UTC by Simon Feltman
Modified: 2013-12-01 22:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
annotations: Set GtkTreeModelFilterModifyFunc value argument to out (1.40 KB, patch)
2013-11-28 04:08 UTC, Simon Feltman 		committed Details | Review

Description Simon Feltman 2013-11-28 04:07:51 UTC 
Since GI based language bindings coerce GValues into native types, there is no way to make use of "value" argument as an input argument which is set to a specific value. We should mark this argument as (out caller-allocates) so closures can return a value instead.
Comment 1 Simon Feltman 2013-11-28 04:08:45 UTC 
Created attachment 262993 [details] [review]
annotations: Set GtkTreeModelFilterModifyFunc value argument to out

Use (out caller-allocates) annotation for the "value" argument to
GtkTreeModelFilterModifyFunc. This is needed because GI based language
bindings coerce GValue input args into native types and there is no
opportunity to set the value within the GValue itself.
Comment 2 Matthias Clasen 2013-12-01 18:43:45 UTC 
Review of attachment 262993 [details] [review]:

looks ok to me
Comment 3 Matthias Clasen 2013-12-01 22:22:18 UTC 
Attachment 262993 [details] pushed as af95d66 - annotations: Set GtkTreeModelFilterModifyFunc value argument to out