GNOME Bugzilla – Bug 719370
Atspi initiates with magnifier activation instead of tracker registration
Last modified: 2014-02-10 18:54:49 UTC
https://git.gnome.org/browse/gnome-shell/commit/js/ui/magnifier.js?id=193f872ebedfb1fb1107a428b595855812f42153 The commit above was done to 'damage-limit' the magnifiers call to focus and caret tracker because of a bug which was present with Atspi initialisation in my view however, Atspi is initialised in the tracker which is only called when the tracking for caret and focus are registered by the magnifier - not when it is activated so if we want to do damage limitation of atspi then we need to do it only when we register Atspi. I apologise for not having done this earlier I simply did not want to have Atspi initiated in either way to be honest. However, it is nearly december and atspi still needs refining to work fully in its gnome-shell implementation. I cannot fix at-spi2-core myself any time soon, so I figured this has to be done -at least until the patch I am currently working for gnome-shell is ready, or someone else is able to work on the atspi issue directly that is. Thanks
Created attachment 262882 [details] [review] handle the initialisation of atspi more cleanly
Created attachment 262887 [details] [review] handle the initialisation of atspi more cleanly I noticed a style inconsistency so just a style amended version the previous patch to fix it.
Created attachment 262890 [details] [review] Atspi init actually happens registering with ZoomRegions of Magnifier Sorry just realised I had a rubbish commit message, this one should be clearer.