After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719335 - Make appdata file translatable
Make appdata file translatable
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-26 09:04 UTC by Daniel Mustieles
Modified: 2014-02-10 09:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to make Appdata file translatable (3.66 KB, patch)
2013-11-26 09:04 UTC, Daniel Mustieles 		accepted-commit_now Details | Review

Description Daniel Mustieles 2013-11-26 09:04:15 UTC 
Created attachment 262812 [details] [review]
Patch to make Appdata file translatable

This patch makes the AppData file translatable
Comment 1 Daniel Mustieles 2014-01-21 11:23:48 UTC 
Hey! Could somebody please review this patch?

I'd like to commit it, as there is a GNOME Goal open for it.

Thanks!
Comment 2 Evgeny Bobkin 2014-01-29 11:19:58 UTC 
Thank you for the patch. I have not tested it myself, at first glance it looks okey to me, however

by the way is the order of this definitions in Makefile.am correct?

23      dist_appdata_DATA = $(appdata_in_files:.xml.in=.xml)
24	appdata_in_files = data/appdata/gnome-clocks.appdata.xml.in
Comment 3 Daniel Mustieles 2014-01-29 11:25:01 UTC 
This is the same order used in other modules, without problems, so it should not be a problem here ;)

Anyway, it's just a definition of two variables, so order should not be a problem... they are used below in the Makefile.am.
Comment 4 Paolo Borelli 2014-02-07 17:54:42 UTC 
Review of attachment 262812 [details] [review]:

sorry for the delay, please commit
Comment 5 Daniel Mustieles 2014-02-10 08:56:50 UTC 
Commited with slightly modifications, as the appdata file has changed it's name.

Thanks!
Comment 6 Evgeny Bobkin 2014-02-10 09:04:39 UTC 
(In reply to comment #5)
> Commited with slightly modifications, as the appdata file has changed it's
> name.
> 
> Thanks!

Thank you for this contribution, this is a much better patch.