After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 719240 - Publishing dialog can be minimized in Unity
Publishing dialog can be minimized in Unity
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: ux
unspecified
Other All
: Normal normal
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-27 07:52 UTC by Shotwell Maintainers
Modified: 2017-03-24 18:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Disable minimize button on Unity (927 bytes, patch)
2017-03-24 18:48 UTC, Jens Georg
committed Details | Review

Description Charles Lindsay 2013-11-25 22:11:04 UTC


---- Reported by shotwell-maint@gnome.bugs 2013-05-27 12:52:00 -0700 ----

Original Redmine bug id: 7009
Original URL: http://redmine.yorba.org/issues/7009
Searchable id: yorba-bug-7009
Original author: Tomáš Hnyk
Original description:

How to reproduce:

1. Select a photo and click on publish.

2. Minimize the new window that poped out.

3. Select and event and press F2.

What happens:

Nothing

What should happen:

A dialog to rename the event should appear.

Also, clicking on the main window does not bring it to foreground, I think the
publish plugin grabs too much focus (this is under unity on 13.04, if it
matters, Shotwell installed from Ubuntu's repositories.

Related issues:
related to shotwell - Feature #2318: publish in background (Open)



---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-27 17:16:00 -0700 ----

### History

####

#1

Updated by Jim Nelson 6 months ago

  * **Subject** changed from _When publish dialogs in other windows are open, keyboard shortucts do not work_ to _Publishing dialog can be minimized in Unity_
  * **Category** set to _ux_

The publishing dialog is designed to work modally. That is, when it's up you
shouldn't be able to use the rest of the Shotwell app. See #2318.

What's going on here is that Unity is allowing for the minimize button to be
displayed, and when it's displayed, to minimize only that window. That's not
how it works under GNOME 3 Shell, which doesn't give the user a minimize
button.

Fixing this, then, means fixing Shotwell under Unity so the publishing dialog
isn't displayed. I've changed the title accordingly.



--- Bug imported by chaz@yorba.org 2013-11-25 22:11 UTC  ---

This bug was previously known as _bug_ 7009 at http://redmine.yorba.org/show_bug.cgi?id=7009

Unknown version " in product shotwell. 
   Setting version to "!unspecified".
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Resolution set on an open status.
   Dropping resolution 

Comment 1 tobia.tesan 2014-09-21 21:37:01 UTC
Don't take my word for it, but *shouldn't*, in theory, setting Gdk.WindowTypeHint.DIALOG and/or set_modal() be enough?

(In practice it doesn't work, though).
Comment 2 tobia.tesan 2015-02-21 15:45:41 UTC
This works for me under Ubuntu 14.10: https://github.com/tobiatesan/shotwell/commit/b58096af6a7a680a07bc5369ab06a153dba52000
Comment 3 Tomáš Hnyk 2015-02-21 16:01:42 UTC
Well attach a patch, hopefully somebody will notice.
Comment 4 tobia.tesan 2015-02-21 16:05:03 UTC
Thing is, it doesn't work, sorry.

All is good and well until you maximize the main window and restore it to unmaximized state again.

Then the modal dialog is not modal anymore.

Sorry, I didn't expect that.

Let me see what's wrong.
Comment 5 Jens Georg 2017-03-24 18:48:50 UTC
Created attachment 348666 [details] [review]
Disable minimize button on Unity

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 6 Jens Georg 2017-03-24 18:49:59 UTC
Attachment 348666 [details] pushed as a94a5c6 - Disable minimize button on Unity