GNOME Bugzilla – Bug 719188
Remove all symbols deprecated in GTK 3.14
Last modified: 2017-03-21 22:59:22 UTC
---- Reported by jim@yorba.org 2013-08-05 14:59:00 -0700 ---- Original Redmine bug id: 7301 Original URL: http://redmine.yorba.org/issues/7301 Searchable id: yorba-bug-7301 Original author: Jim Nelson Original description: The number of symbols and classes to be deprecated in GTK 3.10 is a huge hit on Shotwell and will require a significant reworking to fix. Some of the biggees include: * GtkStock (including all things gtk_*_from_stock() and the use of GtkStock in the Glade files) * GtkUIManager * GtkIconFactory * GtkAction / GtkActionGroup The big tasks ahead mean reworking Page and AppWindow and their subclasses to use the replacement GTK classes. Related issues: related to shotwell - 7295: Doesn't build with Vala 0.21.1 (Fixed) --- Bug imported by chaz@yorba.org 2013-11-25 22:00 UTC --- This bug was previously known as _bug_ 7301 at http://redmine.yorba.org/show_bug.cgi?id=7301 Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Created attachment 296879 [details] [review] starting to drop gtk.stock With the attached patch, around 50 deprecation warnings are gone.
Thanks! I've pushed your patch to master, commit d03137.
Created attachment 297315 [details] [review] removing all Gtk.Stock items Down to 14 regression warnings. Gtk.Stock is removed completely. There is one regression, the right-click close menu of the searchbar no longer has an icon. With ImageMenuItem deprecated, it is not that easy to add an icon there. The patch changes quite some files, including the Makefile. I hope that it does not break anything.
Great work! I had some trouble with the patch (I think due to the icon being renamed) but worked around it. No worries about the menu icon. Pushed to master, commit 05a4ba
Created attachment 328317 [details] [review] Remove deprecated call to render_icon Signed-off-by: Jens Georg <mail@jensge.org>
Comment on attachment 328317 [details] [review] Remove deprecated call to render_icon Attachment 328317 [details] pushed as 93b2978 - Remove deprecated call to render_icon
Most are gone now. Some left-overs which need to be still adressesd is mainly GtkIconFactory related
GtkIconFactory also gone with https://git.gnome.org/browse/shotwell/commit/?id=7589900c4ee3f790fd57474a64978193bd839424
Superseded by bug 774650