GNOME Bugzilla – Bug 718783
Update build system & i18n scripts to use intltool, other standard tools
Last modified: 2014-01-15 19:55:41 UTC
---- Reported by lucas@yorba.org 2012-10-10 11:20:00 -0700 ---- Original Redmine bug id: 5982 Original URL: http://redmine.yorba.org/issues/5982 Searchable id: yorba-bug-5982 Original author: Lucas Beeler Original description: We first implemented international support in Shotwell more than 3 years ago. At that time, many of the standard GNOME i18n tools -- most notably intltool -- could not be made to work easily with our custom build system and/or Vala. Fast forward 3 years and the tools have evolved, so much so that Jim was able to use things like intltool and gettext annotations during the internationalization of Geary. We should update our i18n workflow in Shotwell to use standard tools and practices, especially since Canonical has complained about our static POT files. ---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-16 14:27:00 -0700 ---- ### History #### #1 Updated by Jim Nelson 11 months ago * **Category** set to _build_ #### #2 Updated by Jim Nelson 9 months ago * **Target version** changed from _0.14.0_ to _0.15.0_ #### #3 Updated by Jim Nelson 6 months ago * **Target version** deleted (<strike>_0.15.0_</strike>) --- Bug imported by chaz@yorba.org 2013-11-25 21:58 UTC --- This bug was previously known as _bug_ 5982 at http://redmine.yorba.org/show_bug.cgi?id=5982 Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. Resolution set on an open status. Dropping resolution
Charles is getting ready to commit changes to Geary which allow for it to work with GNOME's Damned Lies. We should perform similar work with Shotwell to make that happen as well: * No longer store .pot file in source control * intltool-update can generate .pot file (need to add list files to po/) * Verify that .po file is not updated by build process (this was an error we found in Geary's script, unsure this is present in Shotwell) There may be other work, but this what we learned while going through the process for Geary.
See also bug #716533.
This is up at wip/l10n-718783. It builds, it makes tarballs, and those tarballs build, install, and seem to run fine. I didn't try publishing anything, nor did I test on another language yet. I'll sit on this at least till tomorrow. Want to review?
FWIW, it looks correct from l10n/damned-lies point of view. Good work! :)
Great, glad to hear it! I'll see if Jim has anything to say about it, and hopefully get this committed today. Thanks.
Charles and I discussed and agreed to go the extra mile and get the help documentation prepared for DL as well, so commit will happen once that's ready.
Done in commit e9f5eef. Added the Makefile.am for help as well.