After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 717438 - Segfault can occur when working with GExiv2 metadata
Segfault can occur when working with GExiv2 metadata
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: general
0.9
Other All
: Urgent normal
: ---
Assigned To: Lucas Beeler
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-24 10:03 UTC by Shotwell Maintainers
Modified: 2013-05-01 06:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core_flickr.txt (45.87 KB, text/plain)
2011-02-24 22:03 UTC, Shotwell Maintainers
Details
core_flickr2.txt (46.53 KB, text/plain)
2011-02-24 22:03 UTC, Shotwell Maintainers
Details

Description Charles Lindsay 2013-11-25 21:51:09 UTC


---- Reported by shotwell-maint@gnome.bugs 2011-02-24 14:03:00 -0800 ----

Original Redmine bug id: 3257
Original URL: http://redmine.yorba.org/issues/3257
Searchable id: yorba-bug-3257
Original author: Vera Yin
Original description:

This happened twice, have not been able to reproduce it since.

1) While not logged in to Flickr, select a photo and click Publish.

2) When logging in to Flickr, check 'Keep me signed in' and attempt to sign in
with an invalid password twice.

3) Give the correct password on the third try, approve Shotwell Connect.

4) Click Publish and Shotwell crashes with a segmentation fault.

Two backtraces attached.



---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----

### History

####

#1

Updated by Adam Dingle over 2 years ago

  * **Target version** set to _0.9_

####

#2

Updated by Lucas Beeler over 2 years ago

Jim and I investigated this and we discovered that this bug occurs because we
likely misinterpreted the semantics of the “CCode (array_null_terminated =
true)]†markup that we use in GExiv2's VAPI. Specifically, we had assumed
that this markup instructed the Vala compiler to automatically add a
terminating null entry to the array, whereas it now appears that the markup is
just a tag marking the array as null terminated, making the caller responsible
for appending a terminating null to the array argument before invoking the
marked-up function. So we should've been adding a terminating null to an array
argument, but we weren't. This affects code in both the Flickr publisher (as
originally reported) and also in PhotoMetadata.vala.

####

#3

Updated by Lucas Beeler over 2 years ago

  * **Subject** changed from _seg fault after failed login attempts to flickr_ to _Segfault can occur when working with GExiv2 metadata_

####

#4

Updated by Jim Nelson over 2 years ago

See also #3264.

####

#5

Updated by Adam Dingle over 2 years ago

  * **Status** changed from _Open_ to _Review_
  * **Assignee** changed from _Anonymous_ to _Lucas Beeler_

Lucas has a fix pending.

####

#6

Updated by Lucas Beeler over 2 years ago

  * **Status** changed from _Review_ to _5_
  * **Resolution** set to _fixed_
  * **% Done** changed from _0_ to _100_

r2679

####

#7

Updated by Charles Lindsay 7 months ago

  * **Status** changed from _5_ to _Fixed_



--- Bug imported by chaz@yorba.org 2013-11-25 21:51 UTC  ---

This bug was previously known as _bug_ 3257 at http://redmine.yorba.org/show_bug.cgi?id=3257
Imported an attachment (id=261988)
Imported an attachment (id=261989)

Unknown Component 
   Using default product and component set in Parameters 
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.