After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 717138 - generate thumbnails by forking totem-video-thumbnailer
generate thumbnails by forking totem-video-thumbnailer
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: general
0.9
Other All
: High normal
: ---
Assigned To: Eric Gregory
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-02 08:46 UTC by Adam Dingle
Modified: 2013-05-01 06:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Charles Lindsay 2013-11-25 21:49:30 UTC


---- Reported by adam@yorba.org 2011-02-02 12:46:00 -0800 ----

Original Redmine bug id: 3147
Original URL: http://redmine.yorba.org/issues/3147
Searchable id: yorba-bug-3147
Original author: Adam Dingle
Original description:

Shotwell 0.8 generates video thumbnails by using GStreamer directly.
Unfortunately we've found that this occasionally hangs for certain obscure
videos. We've fiddled with GStreamer parameters (including the 'flush' flag),
but haven't found a set of parameters that works reliably for all videos.

Nautilus generates video thumbnails by calling totem-video-thumbnailer. Eric
has spent some time trying to tweak our video thumbnailing code to look more
like the code in totem-video-thumbnailer. Unfortunately that code is
complicated and looks like it contains various workarounds for GStreamer bugs,
and I don't think we want to try to duplicate that.

I've become convinced that in the short term, i.e. for 0.9, we should generate
thumbnails by calling totem-video-thumbnailer ourselves. This will have two
benefits:

We can reuse the existing thumbnailing code rather than trying to duplicate
it.

If we find that totem-video-thumbnailer ever hangs, we can put in a timeout
that kills it if necessary. Doing so on GStreamer code running in our own
process would be much more dangerous.

In the long term, I think we should do either of these:

convince the GStreamer developers to fix their bugs (or help them do so) so
that we can simply call GStreamer in-process as we originally tried

enhance the GNOME thumbnailing API (which calls totem-video-thumbnailer behind
the scenes) so that we can ask for a JPEG thumbnail at an arbitrary
resolution; then we could simply retrieve our thumbnails using this API



---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:39:00 -0700 ----

### History

####

#1

Updated by Eric Gregory almost 3 years ago

  * **Status** changed from _Open_ to _5_
  * **Resolution** set to _fixed_
  * **% Done** changed from _0_ to _100_

Done. We're now dependent on totem for those who want thumbnails of their
videos.

r2620

####

#2

Updated by Charles Lindsay 7 months ago

  * **Status** changed from _5_ to _Fixed_



--- Bug imported by chaz@yorba.org 2013-11-25 21:49 UTC  ---

This bug was previously known as _bug_ 3147 at http://redmine.yorba.org/show_bug.cgi?id=3147

Unknown Component 
   Using default product and component set in Parameters 
Unknown milestone "unknown in product shotwell. 
   Setting to default milestone for this product, "---".
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.