GNOME Bugzilla – Bug 716456
provide toolbar buttons to switch between browser and full-window views
Last modified: 2013-05-01 06:46:00 UTC
---- Reported by shotwell-maint@gnome.bugs 2010-06-13 03:03:00 -0700 ---- Original Redmine bug id: 2106 Original URL: http://redmine.yorba.org/issues/2106 Searchable id: yorba-bug-2106 Original author: Kostas - Original description: Shotwell does not have the option to go back and browse the photos when you are editing a photo. ---- Additional Comments From shotwell-maint@gnome.bugs 2013-05-01 11:46:00 -0700 ---- ### History #### #1 Updated by Adam Dingle over 3 years ago It's unclear what you're asking for here. Are you requesting for Shotwell to be able to display the photo editor and the photo browser in two separate panes at the same time? It sounds like you're proposing two new buttons named 'Browse' and 'Edit image'. When and where would these buttons appear, and what would they do? #### #2 Updated by Kostas - over 3 years ago Below I have a screenshot with the two buttons (the screenshot will make it clear): http://f-spot.org/images/thumb/a/aa/Main-window.png/800px-Main-window.png #### #3 Updated by Adam Dingle over 3 years ago * **Subject** changed from _Create a button 'Browse' and 'Edit image' to navigate_ to _provide toolbar buttons to switch between browser and full-window views_ OK, now I understand your request better: you'd like toolbar buttons that switch between the browser view and the full-window view (which is also used for editing). #### #4 Updated by Kostas - over 3 years ago Yes, this will make it easier to switch. #### #5 Updated by Jani Monoses about 3 years ago the link to the screenshot is 404 #### #6 Updated by Jani Monoses about 3 years ago A patch for a possible solution to this. Since this has a significant UI/UX component I am aware this needs to be done “the Shotwell way†(which I cannot fully infer from the current UI). This adds a toolbar button called View and using the same icon as F-spot (they go fullscreen for this action so it is not a 100% match). This goes to edit/view mode but saves the selection before switching. On return it is restored. My current doubts are: * naming of action, label, tooltip, – not sure what it should be, View Large or Edit. The confusing bit is that this use case is actually a temporary Zoom Max but uses the Edit mode since that gives this functionality already * icon – obviously subject to change * does it need a menu action as well? I put it in the View menu just in case. What is the a convention wrt putting actions in toolbars vs menus vs both? The current menu action has the hotkey Ctrl-V which does not work since I would have had to modify the on_activate method which looks at modifiers and does nothing if Ctrl is pressed – the Return key also goes into Edit mode. I did not complicate the path until it is clearer which are going to be the means to switch to this mode. * returning – I think Escape is ok, no need to add an extra return path/ toolbar icon IMHO. If selection was saved it is restored, if not, not. I think it may be easier to just have Return work as it does now but also activatable on many selected not just one and with saving the selection. Then there would be no need for an extra key. I also think that double click to edit should preserve selection, but that looks weird as between the two clicks the other items get unselected, so it would be confusing and the implementation a bit more convoluted (I have tried that a while ago). But that would be the most intuitive – as double click would mean I want to see this large or edit it, but leave the current selection alone for when I get back. Anyway I hope with your input this feature can be included in one way or another. #### #7 Updated by Adam Dingle about 3 years ago * **Status** changed from _Open_ to _5_ * **Resolution** set to _wontfix_ * **% Done** set to _0_ Jani, thanks for the patch, but unfortunately we're not interested in this change. Space on the toolbar is precious, and on netbooks with screens that are 1024 pixels wide we're already pretty much out of room. Currently a user can open a photo either by double clicking or by pressing Enter. I think those mechanisms are easy to use and discover, so I don't see why we need another one. It seems that you'd like some way to enter the full-window view while still preserving a multi-image selection. I don't see why this is so important, and it seems odd to me to allow someone to enter full-window view when multiple images are selected since it's not clear which one to display. If there's some use case I'm missing here, feel free to explain. The person who originally filed this bug wanted some other way to get back from full-window view back to browser view. Either double clicking or Escape works for that. Those are slightly less discoverable, but still not hard to figure out, and we can certainly add a FAQ entry if we find this is confusing people. Given all this, I'm inclined to mark this bug as wontfix. If you strongly want this change, feel free to continue this discussion here. And thanks again for all your other fixes. #### #8 Updated by Jani Monoses about 3 years ago Thanks for the feedback, Adam. I expect any feature request to be evaluated and I have absolutely no problem if after discussing them they are not included. Maybe the original bug reporter only needed a new way to get back because double-click or escape is not discoverable, but in this case this is not a duplicate (albeit similar) of the issue I filed originally, #2161 , where I described the use case. I agree with wontfix on this particular issue, I personally only added toolbar buttons because my original issue was attached to this and I thought this was a superset of what I wanted. Basically I only want a way – keyboard shortcut being more than enough – to switch to edit/view mode and see a photo in full size, but without losing selection. I believe this use case was brought up recently on the mailing list as well. I sometimes have over a dozen very similar photos (of people) from which I would like to select one or two to upload to the web. Even at the max zoom level in the collection view they look too similar, but if I see them in full size I can decide easier. If in an event page I have 3 or 4 such similar groups, I'd like to pick a total of maybe 8 photos out of 40, so I start selecting but when I need a better view and switch to edit mode I lose the selection. So I needed a fix/hack like the one filed in this issue to avoid me having to keep mumbling something like “3rd, 5th, 8th and 10th†before switching to edit mode, so I remember and can quickly reselect those on return. I think you agree this is suboptimal :) Another way of doing it is having a file manager open side by side but I think this can be done in Shotwell without much harm. So I'll gladly strip out the extra UI items and if you agree this is a valid use case resubmit a patch with only a hotkey. A slightly different approach which would fix this issue for me is not going into edit mode at all, but have a hotkey for maximum zoom, which would only show one photo stretched out, similar to edit mode but keeping the browse mode toolbar. I think this is a technically cleaner way but needs more work and thought regarding keyboard navigation. #### #9 Updated by Jani Monoses about 3 years ago I forgot to add, that the 404 link to an F-Spot screenshot that was mentioned earlier in this issue made me check out F-Spot and indeed it has such a toolbar button going into full screen, but on Escape the selection is preserved. #### #10 Updated by Charles Lindsay 7 months ago * **Status** changed from _5_ to _Invalid_ --- Bug imported by chaz@yorba.org 2013-11-25 21:45 UTC --- This bug was previously known as _bug_ 2106 at http://redmine.yorba.org/show_bug.cgi?id=2106 Imported an attachment (id=261710) Imported an attachment (id=261711) Unknown Component Using default product and component set in Parameters Unknown version " in product shotwell. Setting version to "!unspecified". Unknown milestone "unknown in product shotwell. Setting to default milestone for this product, "---". Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.