After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715196 - [review] dcbw/matching-cleanups
[review] dcbw/matching-cleanups
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-25 21:20 UTC by Dan Williams
Modified: 2013-12-02 21:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Dan Williams 2013-11-25 21:20:23 UTC 
Random cleanups spawned from the connection matching work.
Comment 1 Thomas Haller 2013-11-27 13:22:51 UTC 
All patches look good to me.

If anything, could you add a comment to the commit message of
  >> Revert "device: bind the generated loopback connection to 'lo' interface"
why you reverted it? Obviously, because the following commit implements it differently, but would be nice if you could state the reasoning shortly.
Comment 2 Dan Williams 2013-12-02 21:34:11 UTC 
Commit message fixed and branch merged, thanks!