GNOME Bugzilla – Bug 715181
NMManager:startup is broken due to stalled device activation
Last modified: 2013-11-27 13:55:08 UTC
just noticed while debugging something else: 72795] [nm-manager.c:767] check_if_startup_complete(): check_if_startup_complete returns FALSE because of lo danw@laptop:~> nmcli -f STARTUP -t gen status starting (This is well after startup.)
actually, lo is innocent (it unblocks startup shortly after). It was virbr0 that was causing the problem
Created attachment 262884 [details] [review] devices: if IP4 and IP6 config both fail right away, fail the device Previously, the device activation would stall in this case, because the code wasn't expecting it to happen. In particular, this happens when trying to assume a device that is up but has no IP config.
looks good to me
The current patch looks correct. However, at some point (soon?) we want to support Layer2-only configurations for at least ethernet devices, if only for bridge/bond and DCB. Jiri Pirko posted some patches starting on that earlier this fall to the mailing list, which I haven't had time to look at yet. This patch would break that, but there are also other assumptions in the code that need to be fixed up first (ie, these devices can never be 'default' since they don't have IP configuration, and the policy needs to handle that). We should file another bug for that though, and attach jpirko's patches, and then assign it to somebody :)
Attachment 262884 [details] pushed as ff93ed6 - devices: if IP4 and IP6 config both fail right away, fail the device