After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715053 - SSH key generation is broken
SSH key generation is broken
Status: RESOLVED DUPLICATE of bug 715051
Product: seahorse
Classification: Applications
Component: general
3.10.x
Other Linux
: Normal major
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2013-11-23 04:46 UTC by Michael Catanzaro
Modified: 2013-11-23 04:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix SSH key generation (1.01 KB, patch)
2013-11-23 04:47 UTC, Michael Catanzaro
none Details | Review

Description Michael Catanzaro 2013-11-23 04:46:56 UTC
SSH key generation is broken since https://github.com/GNOME/seahorse/commit/0688d474c2070873905615f1b2bad876e41d27a0

The for loop in seahorse_ssh_source_file_for_algorithm is no longer entered after i was changed from a guint to a gint, so no file is ever created.  We could change it back to a guint, but it might break again.

This would be good for a 3.10.2.
Comment 1 Michael Catanzaro 2013-11-23 04:47:36 UTC
Created attachment 261282 [details] [review]
Fix SSH key generation

Here, i used to be a guint, but was recently changed into a gint to
silence a compiler warning. This caused the for loop to terminate
without ever iterating.
Comment 2 Michael Catanzaro 2013-11-23 04:49:43 UTC
I went to add a See Also to a downstream bug, and it was already there. :)

*** This bug has been marked as a duplicate of bug 715051 ***