After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 715042 - Add translator comment on how to translate 'calendar:MY'
Add translator comment on how to translate 'calendar:MY'
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-22 22:12 UTC by Reinout van Schouwen
Modified: 2014-04-27 00:07 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
Add translator comment on how to translate 'calendar:MY' (1.32 KB, patch)
2014-02-06 18:40 UTC, Yosef Or Boczko 		rejected Details | Review
calendar: Don't mark translations from GTK+ for translation (1.40 KB, patch)
2014-04-26 23:39 UTC, Florian Müllner 		committed Details | Review

Description Reinout van Schouwen 2013-11-22 22:12:53 UTC 
Looking at the source in calendar.js, 'calendar:MY' should probably be translated as %B %Y or %Y %B depending on locale. This is completely unclear for translators. Please add a translator comment and use the default US English month/year convention as msgid.
Comment 1 Yosef Or Boczko 2014-02-06 18:40:45 UTC 
Created attachment 268329 [details] [review]
Add translator comment on how to translate 'calendar:MY'

This is copy of the comment from GTK+.
Comment 2 drago01 2014-02-13 18:31:06 UTC 
Review of attachment 268329 [details] [review]:

OK.
Comment 3 Florian Müllner 2014-04-26 23:38:58 UTC 
Review of attachment 268329 [details] [review]:

I was about to push this, but ... we pick up the translation from GTK+, so all translations of this string done for gnome-shell are just ignored. So rather than a translator comment, we should make sure that the string is not marked for translation in the first place.
Comment 4 Florian Müllner 2014-04-26 23:39:37 UTC 
Created attachment 275241 [details] [review]
calendar: Don't mark translations from GTK+ for translation

The order in which month and year are displayed is controlled by
a "special" translated string in GTK+. We pick up the translation
from there, so make sure that it doesn't get translated again
in gnome-shell.
Comment 5 Jasper St. Pierre (not reading bugmail) 2014-04-27 00:04:04 UTC 
Review of attachment 275241 [details] [review]:

Nice catch.
Comment 6 Florian Müllner 2014-04-27 00:07:01 UTC 
Attachment 275241 [details] pushed as 6ece67b - calendar: Don't mark translations from GTK+ for translation