After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712816 - device-manager-evdev: Stop using deprecated libevdev API
device-manager-evdev: Stop using deprecated libevdev API
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-11-21 14:40 UTC by Rui Matos
Modified: 2013-11-22 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
device-manager-evdev: Stop using deprecated libevdev API (3.56 KB, patch)
2013-11-21 14:40 UTC, Rui Matos 		accepted-commit_now Details | Review
device-manager-evdev: Stop using deprecated libevdev API (4.78 KB, patch)
2013-11-21 15:40 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2013-11-21 14:40:18 UTC 
Not sure if want/can start depending on newer libevdev API right away
but I'm using this to kill some compiler warnings.
Comment 1 Rui Matos 2013-11-21 14:40:20 UTC 
Created attachment 260448 [details] [review]
device-manager-evdev: Stop using deprecated libevdev API

Fixes compiler warnings with libevdev >= 0.4 and makes use of a new
function to set the clock id instead of doing the ioctl directly.
Comment 2 Emmanuele Bassi (:ebassi) 2013-11-21 14:48:30 UTC 
Review of attachment 260448 [details] [review]:

looks okay to me. you should also add a release note in README.in for Clutter 1.18 about the new dependency.

::: configure.ac
@@ +481,3 @@
               [
                 CLUTTER_INPUT_BACKENDS="$CLUTTER_INPUT_BACKENDS evdev"
+                BACKEND_PC_FILES="$BACKEND_PC_FILES gudev-1.0 libevdev >= 0.4 xkbcommon"

the version should probably be m4-ised, so that we don't have to hunt down the line if we need to bump the requirement.
Comment 3 Rui Matos 2013-11-21 15:40:08 UTC 
Created attachment 260459 [details] [review]
device-manager-evdev: Stop using deprecated libevdev API

--
Like this?
Comment 4 Emmanuele Bassi (:ebassi) 2013-11-21 16:31:17 UTC 
Review of attachment 260459 [details] [review]:

that's precisely what I had in mind, thanks.

looks good now.
Comment 5 Rui Matos 2013-11-22 10:22:36 UTC 
Attachment 260459 [details] pushed as 3cd9a70 - device-manager-evdev: Stop using deprecated libevdev API