After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712776 - gst-rtsp-server: remove transports if media is in error status
gst-rtsp-server: remove transports if media is in error status
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-20 23:51 UTC by Aleix Conchillo Flaqué
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remove transports when media in error status (2.09 KB, patch)
2013-11-21 00:04 UTC, Aleix Conchillo Flaqué 		none Details | Review
remove transports when media in error status (1.72 KB, patch)
2013-11-21 00:06 UTC, Aleix Conchillo Flaqué 		none Details | Review

Description Aleix Conchillo Flaqué 2013-11-20 23:51:34 UTC 
If media is prepared and then set with the error status (e.g. udpsrc internal error), the media streams won't be able to leave the bin if transports have not been previously removed.

I've hit this by having an srtpbin (hopefully to be shared soon) instead of an rtpbin and no decoders in the client side (which obviously generates all kind of errors there too).
Comment 1 Aleix Conchillo Flaqué 2013-11-21 00:04:22 UTC 
Created attachment 260397 [details] [review]
remove transports when media in error status

This patch removes the transports if media is in error status and media is changing to NULL state.
Comment 2 Aleix Conchillo Flaqué 2013-11-21 00:06:01 UTC 
Created attachment 260398 [details] [review]
remove transports when media in error status

Sorry, this one instead. Forgot to remove reference to the srtpbin.
Comment 3 Wim Taymans 2013-11-22 10:25:56 UTC 
commit b6d4a29d75b5a7bc8debe796b4092e55664b638b
Author: Aleix Conchillo Flaque <aleix@oblong.com>
Date:   Wed Nov 20 15:51:54 2013 -0800

    rtsp-media: remove transports if media is in error status
    
    * gst/rtsp-server/rtsp-media.c (gst_rtsp_media_set_state): if we are
      trying to change to GST_STATE_NULL and media is in error status, we
      remove all transports.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=712776