After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712635 - no indication in private message that the person disconnected
no indication in private message that the person disconnected
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-18 21:20 UTC by William Jon McCann
Modified: 2017-04-10 22:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
userTracker: Improve status tracking for private chats (2.81 KB, patch)
2017-04-10 22:08 UTC, Florian Müllner
committed Details | Review
chatView: Disconnect channel when contact leaves from conversation (1.23 KB, patch)
2017-04-10 22:09 UTC, Florian Müllner
committed Details | Review

Description William Jon McCann 2013-11-18 21:20:00 UTC
There is no indication in private message room that the person disconnected.
Comment 1 Vincent Untz 2015-04-16 09:34:32 UTC
Even worse, when I type a message, there's no indication that it goes to /dev/null.
Comment 2 Philip Withnall 2016-03-06 17:56:54 UTC
I've been looking at implementing this, but I think it needs changes to telepathy-idle to actually support signalling that the peer in an ImChannel has disconnected. I did some testing with Polari on two machines, opened a private chat, sent some messages, started inspecting the D-Bus traffic, then disconnected one of the accounts — there was no relevant D-Bus traffic to notify of this on the other machine at all (only MembersChanged signals on the org.fdo.Telepathy.Channel.Interface.Group interface for the other rooms the account was present in).
Comment 3 Florian Müllner 2017-04-10 22:08:31 UTC
I agree that a proper fix would require changes to telepathy-idle, but as we now plan to move away from telepathy altogether, I think it is fine to work around the issue in the meantime.
Comment 4 Florian Müllner 2017-04-10 22:08:55 UTC
Created attachment 349639 [details] [review]
userTracker: Improve status tracking for private chats

The ::group-contacts-changed signal is limited to channels implementing
the group interface, so we miss when the remote contact disconnects from
a private chat. Work around this by ignoring contacts from one-to-one
chats for the global status, and remove contacts from all rooms when their
global status becomes OFFLINE.
Comment 5 Florian Müllner 2017-04-10 22:09:02 UTC
Created attachment 349640 [details] [review]
chatView: Disconnect channel when contact leaves from conversation

In a one-to-one conversation, there's no reason to keep the channel
open after one of the participants disconnects - all further messages
will go straight to /dev/null anyway - so disconnect the channel in
this case.
Comment 6 Florian Müllner 2017-04-10 22:41:40 UTC
Attachment 349639 [details] pushed as 295a5a0 - userTracker: Improve status tracking for private chats
Attachment 349640 [details] pushed as 1f721d9 - chatView: Disconnect channel when contact leaves from conversation