After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 712313 - filebrowser plugin: hiding binaries breaks file name matching
filebrowser plugin: hiding binaries breaks file name matching
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2013-11-14 16:24 UTC by Volker Sobek (weld)
Modified: 2019-03-23 20:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
filebrowser: Fix filename matching (2.72 KB, patch)
2013-11-15 01:04 UTC, Volker Sobek (weld) 		committed Details | Review

Description Volker Sobek (weld) 2013-11-14 16:24:37 UTC 
When the file browser is set to not show binaries (/org/gnome/gedit/plugins/filebrowser/filter-mode contains 'hide-binary'), entering a search pattern in the search entry has no effect. Filtering by pattern works once you set the filebrowser back to show binaries.
Comment 1 Volker Sobek (weld) 2013-11-15 01:04:44 UTC 
Created attachment 259846 [details] [review]
filebrowser: Fix filename matching

Ensure filename matching in the filebrowser always works. It wasn't
working when the option to show binary files was disabled.

Also, don't filter out directories that match binary-patterns.
Comment 2 Paolo Borelli 2013-11-16 11:28:39 UTC 
Review of attachment 259846 [details] [review]:

Thanks for tracking this down!

Commit both on master and gnome-3-10
Comment 3 Volker Sobek (weld) 2013-11-16 11:50:51 UTC 
Comment on attachment 259846 [details] [review]
filebrowser: Fix filename matching

Attachment 259846 [details] pushed as 79a134e - filebrowser: Fix filename matching