After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711833 - Did I successfully connect?
Did I successfully connect?
Status: RESOLVED OBSOLETE
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Polari maintainers
Polari maintainers
: 755583 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-11-11 11:07 UTC by Andreas Nilsson
Modified: 2021-06-10 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
joinDialog: Update combobox on account changes (3.77 KB, patch)
2014-01-08 20:38 UTC, Florian Müllner
committed Details | Review
ui: Update connection details dialog (13.26 KB, patch)
2014-01-08 20:38 UTC, Florian Müllner
committed Details | Review
ui: Update join dialog (13.25 KB, patch)
2014-01-08 20:38 UTC, Florian Müllner
committed Details | Review
ui: Update message-user dialog (11.99 KB, patch)
2014-01-08 20:39 UTC, Florian Müllner
committed Details | Review
connections: Handle creating/updating accounts in details dialog (7.73 KB, patch)
2014-01-08 20:39 UTC, Florian Müllner
committed Details | Review
connections: Split out connection details (5.80 KB, patch)
2014-01-08 20:39 UTC, Florian Müllner
committed Details | Review
joinDialog: Support adding new connections from within the dialog (23.75 KB, patch)
2014-01-08 20:39 UTC, Florian Müllner
committed Details | Review
app: Never disable room menu and join dialog (1.23 KB, patch)
2014-01-08 20:39 UTC, Florian Müllner
committed Details | Review
ui: Select last used account by default in dialogs (4.54 KB, patch)
2014-08-20 10:08 UTC, Florian Müllner
committed Details | Review
ui: Move initial focus to name entry (1.32 KB, patch)
2014-08-20 10:08 UTC, Florian Müllner
committed Details | Review

Description Andreas Nilsson 2013-11-11 11:07:47 UTC
I connected to the server successfully I think, but there was no indication that I did so, such as a success message or an offer to join a channel.
Comment 1 Javed Ali 2013-11-19 13:31:30 UTC
Hi! I am interested in solving this bug. I am trying to contribute for the first time.

What should the solution be?

A. Topbar (like gitg) showing upon successful connection to a network
B. A simple GTK window upon successful connection.
Comment 2 Jakub Steiner 2013-11-19 13:40:04 UTC
I believe the connection to the server itself is uninteresting. What matters is the connection to the chat room. 

So instead of building UI around connecting to servers, I think we need to revisit the 'join a room' interface and allow to maintain servers in there as well.
Comment 3 Florian Müllner 2013-11-19 13:53:00 UTC
(In reply to comment #2)
> I believe the connection to the server itself is uninteresting.

I agree.


(In reply to comment #1)
> Hi! I am interested in solving this bug. I am trying to contribute for the
> first time.
> 
> What should the solution be?
> 
> A. Topbar (like gitg) showing upon successful connection to a network
> B. A simple GTK window upon successful connection.

Neither of those look very compelling to me - polari tries to restore all previously open rooms on startup, so the expected case would be that you have to click away a couple of dialogs/infobars every time you start the app.

So my take would be to address bug 710271 and bug 709846 first, and then use UI like an infobar for the error case.
Comment 4 Jakub Steiner 2013-11-19 15:13:40 UTC
Yea. We need some connection indicator that would communicate chatroom status (connecting, disconnected).

Here's my initial stab at the workflow for connecting to channels:

https://raw.github.com/gnome-design-team/gnome-mockups/master/polari/connections.png
Comment 5 Florian Müllner 2013-11-20 17:44:27 UTC
(In reply to comment #4)
> Yea. We need some connection indicator that would communicate chatroom status
> (connecting, disconnected).

Ha! First we need to actually keep disconnected rooms open :-)


> Here's my initial stab at the workflow for connecting to channels:
> 
> https://raw.github.com/gnome-design-team/gnome-mockups/master/polari/connections.png

How should we handle connections that exist but are disabled? Do we need some shortcut to the connection list? Or should we just show all connections and just enable them as necessary?
Comment 6 Florian Müllner 2013-11-21 15:05:21 UTC
I just pushed an initial (and incomplete) implementation[0], feedback welcome :-)

[0] https://git.gnome.org/browse/polari?h=join-dialog-refresh
Comment 7 Jakub Steiner 2014-01-08 19:20:11 UTC
(In reply to comment #6)

> [0] https://git.gnome.org/browse/polari?h=join-dialog-refresh

Looks good to me :)
Comment 8 Florian Müllner 2014-01-08 20:38:28 UTC
Created attachment 265769 [details] [review]
joinDialog: Update combobox on account changes

Currently the connection combobox shows the list of accounts that
were available when creating the join dialog. However we will soon
allow to add new connections from within the dialog itself, so we
need to track changes in the list of available accounts to pick up
the additions.
Comment 9 Florian Müllner 2014-01-08 20:38:34 UTC
Created attachment 265770 [details] [review]
ui: Update connection details dialog

Update the UI according to latest mockups:

 - replace section titles with whitespace
 - update content margins
 - make dialog buttons part of the content grid

These changes will make it easier to re-use the UI in the join
dialog to allow adding new connections directly from within the
dialog.
Comment 10 Florian Müllner 2014-01-08 20:38:39 UTC
Created attachment 265771 [details] [review]
ui: Update join dialog

Update the UI according to latest mockups:

 - use custom titlebar
 - replace section titles with whitespace
 - update content margins
 - make dialog buttons part of the content grid

These changes will allow extending the UI to support creating new
connections from within the dialog.
Comment 11 Florian Müllner 2014-01-08 20:39:13 UTC
Created attachment 265772 [details] [review]
ui: Update message-user dialog

Update the UI to make the dialog again consistent with the join
dialog:

 - use custom titlebar
 - replace section titles with whitespace
 - update content margins
 - make dialog buttons part of the content grid
Comment 12 Florian Müllner 2014-01-08 20:39:19 UTC
Created attachment 265773 [details] [review]
connections: Handle creating/updating accounts in details dialog

Currently accounts are created/updated by the connection list in
response to the details dialog, but we will soon allow to create
connections from the join dialog as well, so move the handling
to the code that will be shared between both dialogs.
Comment 13 Florian Müllner 2014-01-08 20:39:24 UTC
Created attachment 265774 [details] [review]
connections: Split out connection details

The join dialog will gain an option to create new connections
from within the dialog. In order to reuse the existing code
from ConnectionDetailsDialog, split out a ConnectionDetails
class which can be shared between the two dialogs.
Comment 14 Florian Müllner 2014-01-08 20:39:30 UTC
Created attachment 265775 [details] [review]
joinDialog: Support adding new connections from within the dialog

For IRC which does not have a real presence concept, setting up
server connections is a requirement for being able to join a room,
but not very interesting on its own; therefore it makes sense to
allow users to set up the required server connections when joining
a room if necessary, keeping the focus on the primary task rather
than requiring them to hunt down the connection editor first.
Comment 15 Florian Müllner 2014-01-08 20:39:37 UTC
Created attachment 265776 [details] [review]
app: Never disable room menu and join dialog

Now that the join dialog allows adding new connections, it no longer
makes sense to disable it when there are no active accounts.
Comment 16 Florian Müllner 2014-01-08 20:41:34 UTC
(In reply to comment #7)
> (In reply to comment #6)
> 
> > [0] https://git.gnome.org/browse/polari?h=join-dialog-refresh
> 
> Looks good to me :)

Cool, thanks! Leaving the bug open, as the implementation of the mockups is not quite complete ...



Attachment 265769 [details] pushed as 78657fc - joinDialog: Update combobox on account changes
Attachment 265770 [details] pushed as 100c572 - ui: Update connection details dialog
Attachment 265771 [details] pushed as 29930b6 - ui: Update join dialog
Attachment 265772 [details] pushed as 94f3781 - ui: Update message-user dialog
Attachment 265773 [details] pushed as c9702fe - connections: Handle creating/updating accounts in details dialog
Attachment 265774 [details] pushed as 03765f5 - connections: Split out connection details
Attachment 265775 [details] pushed as c83d578 - joinDialog: Support adding new connections from within the dialog
Attachment 265776 [details] pushed as d7b5c65 - app: Never disable room menu and join dialog
Comment 17 Florian Müllner 2014-08-20 10:08:05 UTC
Created attachment 283955 [details] [review]
ui: Select last used account by default in dialogs

Connections are currently ordered alphabetically with the first
one selected when opening the dialog. While not arbitrary, this
does not support users in joining the rooms they want as quickly
as possible - remembering the last account used for joining a room
and making it persistent has a higher chance of picking the account
the user wants, so do that instead of always selecting the first one.
Comment 18 Florian Müllner 2014-08-20 10:08:25 UTC
Created attachment 283956 [details] [review]
ui: Move initial focus to name entry

Since we no longer select a "random" account when opening the
join/message dialogs, there's a higher chance that we already
selected the correct account and the user can just enter the
name and confirm - to make this easier, put the initial focus
on the name entry.
Comment 19 Florian Müllner 2014-08-20 10:18:40 UTC
Attachment 283955 [details] pushed as b92901f - ui: Select last used account by default in dialogs
Attachment 283956 [details] pushed as 6e5543f - ui: Move initial focus to name entry

Still missing bits from the design, so not closing quite yet ...
Comment 20 Jakub Steiner 2014-09-05 09:50:34 UTC
I think the initial experience would benefit from having a default server filled in. irc.gnome.org==GNOME would be my suggestion. Right now we depend on people understanding the concept of IRC servers to start chatting.
Comment 21 Florian Müllner 2014-09-05 10:17:09 UTC
I was considering importing empathy's excessive list of IRC networks[0] for entry completion (I refuse to add a combobox or similar for that beast!), but your suggestion sounds a lot simpler ...


[0] https://git.gnome.org/browse/telepathy-account-widgets/tree/tp-account-widgets/irc-networks.xml
Comment 22 Jakub Steiner 2014-09-16 13:46:58 UTC
I think what we have is not enough. I feel like I'm gaffer tape suggesting here, but what about putting a spinner next to the channel name in the headerbar when you're still connecting?
Comment 23 Florian Müllner 2014-09-16 13:50:51 UTC
In addition to the spinner in the app menu and the in-app notification?
Comment 24 Jakub Steiner 2014-09-16 16:08:40 UTC
(In reply to comment #23)
> In addition to the spinner in the app menu and the in-app notification?

The biggest issue I see is when a previous session is being restored. In-app notifications rarely show up for me in this case (I do sometimes see them). The app menu spinner sounds like it should be enough, but i find it lacking. Either the sidebar, text entry or the headerbar seem like where my focus is when I try typing in the channel that isn't really ready for my input..
Comment 25 Florian Müllner 2015-09-24 22:33:13 UTC
*** Bug 755583 has been marked as a duplicate of this bug. ***
Comment 26 André Klapper 2021-06-10 11:05:08 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Polari, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/polari/-/issues/

Thank you for your understanding and your help.