Created attachment 259335 [details] [review]
tweener: Remove the onAnimationStart/onAnimationComplete callbacks

Our gnome-shell tweener integration has had hooks to determine when
the tweens have started and completed... except that they had a bug
in them. When a tween completed, it queued an idle handler to run
the callback in. If no tweens were running when the idle was removing,
it reset the tween state that contained the idle handler ID. It also
returned false, meaning that the source would always get removed.

If the actor had a tween in-flight when the idle was fired, it wouldn't
clean up after itself. While this is also a simple bug fix, remove the
callback so we don't queue unnecessary, unused idles.

Created attachment 259336 [details] [review]
dash: Make sure we clear the timeout ID for the label tooltip

Created attachment 259337 [details] [review]
More invalid source fixes

I had missed the Later one, so didn't attach to bugzilla yet - after rebasing this patch on top of the other ones, we should be good.

Review of attachment 259336 [details] [review]:

Missed _resetHoverTimeout

Review of attachment 259335 [details] [review]:

OK.

Created attachment 259338 [details] [review]
dash: Make sure we clear the timeout IDs for the label tooltip

Review of attachment 259338 [details] [review]:

Yup.

(I'll rebase my patch once those are committed)

Attachment 259335 [details] pushed as 5bc8a08 - tweener: Remove the onAnimationStart/onAnimationComplete callbacks
Attachment 259338 [details] pushed as 3991d27 - dash: Make sure we clear the timeout IDs for the label tooltip

Created attachment 259339 [details] [review]
More invalid source fixes

Review of attachment 259339 [details] [review]:

Yep.

Comment on attachment 259339 [details] [review]
More invalid source fixes

Attachment 259339 [details] pushed as 554d5ae - More invalid source fixes