GNOME Bugzilla – Bug 711673
configure.ac: remove AM_MAINTAINER_MODE
Last modified: 2013-11-09 12:07:58 UTC
Created attachment 259259 [details] [review] configure.ac: remove AM_MAINTAINER_MODE It is very annoying when you edit configure.ac or a Makefile.am, and running "make" does not automatically regenerate all affected generated files.
For some build tools where you loose timestams it's still useful to have it. I agree it should be disabled by default, so I am fine with removing the configure flag in autogen.sh, but I don't think it should be completely removed from configure.ac
(In reply to comment #1) > For some build tools where you loose timestams it's still useful to have it. Are there any such build tools left? Debian used to have that problem, but switched to a more sane source patching years ago. > I agree it should be disabled by default, so I am fine with removing the > configure flag in autogen.sh, but I don't think it should be completely removed > from configure.ac The configure flag in autogen.sh does enable maintainer-mode, which *dis*ables the rebuild rules. So only removing the configure flag from autogen.sh would make the problem worse.
I didn't read this comment and pushed the patch without the configure.ac change. Later fixed in: commit 7abbe4324291100bee40ef5296fc7c4b6c3bc04d Author: Andoni Morales Alastruey <ylatuya@gmail.com> Date: Sat Nov 9 13:00:38 2013 +0100 configure: enable rebuild rules by default
(In reply to comment #3) > I didn't read this comment and pushed the patch without the configure.ac > change. Later fixed in: > > commit 7abbe4324291100bee40ef5296fc7c4b6c3bc04d > Author: Andoni Morales Alastruey <ylatuya@gmail.com> > Date: Sat Nov 9 13:00:38 2013 +0100 > > configure: enable rebuild rules by default Thanks, that looks good to me.
Thank you very much for all the patches, it's the kind of things you always want to fix but never do it :)