After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711553 - gdk/win32: remove extra allocation for \r removal
gdk/win32: remove extra allocation for \r removal
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-11-06 15:15 UTC by Marc-Andre Lureau
Modified: 2013-11-09 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdk/win32: remove extra allocation for \r removal (2.38 KB, patch)
2013-11-06 15:15 UTC, Marc-Andre Lureau
committed Details | Review

Description Marc-Andre Lureau 2013-11-06 15:15:33 UTC
Although I can't find explicit documentation for clipboard pointer, it
seems to be possible to modify clibpoard memory without side-effects.

According to MSDN,
http://msdn.microsoft.com/en-us/library/windows/desktop/aa366596%28v=vs.85%29.aspx

"The global and local functions are supported for porting from 16-bit
code, or for maintaining source code compatibility with 16-bit
Windows. Starting with 32-bit Windows, the global and local functions
are implemented as wrapper functions that call the corresponding heap
functions using a handle to the process's default heap."

"Memory objects allocated by GlobalAlloc and LocalAlloc are in private,
committed pages with read/write access that cannot be accessed by other
processes. Memory allocated by using GlobalAlloc with GMEM_DDESHARE is
not actually shared globally as it is in 16-bit Windows. This value has
no effect and is available only for compatibility. "
Comment 1 Marc-Andre Lureau 2013-11-06 15:15:37 UTC
Created attachment 259089 [details] [review]
gdk/win32: remove extra allocation for \r removal
Comment 2 Matthias Clasen 2013-11-09 04:27:33 UTC
Review of attachment 259089 [details] [review]:

looks reasonable
Comment 3 Matthias Clasen 2013-11-09 17:06:41 UTC
Attachment 259089 [details] pushed as c486c09 - gdk/win32: remove extra allocation for \r removal