After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711432 - avfvideosrc: support screen capture on OSX
avfvideosrc: support screen capture on OSX
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 711211
Blocks: 711606
 
 
Reported: 2013-11-04 18:32 UTC by Matthieu Bouron
Modified: 2014-05-04 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
avfvideosrc: support screen capture on OSX (14.85 KB, patch)
2013-11-04 18:34 UTC, Matthieu Bouron
none Details | Review
avfvideosrc: support screen capture on OSX (11.07 KB, patch)
2013-11-06 14:04 UTC, Matthieu Bouron
committed Details | Review

Description Matthieu Bouron 2013-11-04 18:32:18 UTC
This patch add support of screen capture on OSX through the AVFoundation framework.
Comment 1 Matthieu Bouron 2013-11-04 18:34:31 UTC
Created attachment 258949 [details] [review]
avfvideosrc: support screen capture on OSX
Comment 2 Andoni Morales 2013-11-05 16:11:23 UTC
Review of attachment 258949 [details] [review]:

::: sys/applemedia/avfvideosrc.m
@@ +240,3 @@
+#else
+  AVCaptureScreenInput *screenInput = [[AVCaptureScreenInput alloc] initWithDisplayID:displayId];
+  screenInput.capturesCursor = captureScreenCursor;

This property does not seems to exists:
https://developer.apple.com/library/mac/documentation/AVFoundation/Reference/AVCaptureScreenInput_Class/Reference/Reference.html
Comment 3 Matthieu Bouron 2013-11-05 16:25:31 UTC
(In reply to comment #2)
> Review of attachment 258949 [details] [review]:
> 
> ::: sys/applemedia/avfvideosrc.m
> @@ +240,3 @@
> +#else
> +  AVCaptureScreenInput *screenInput = [[AVCaptureScreenInput alloc]
> initWithDisplayID:displayId];
> +  screenInput.capturesCursor = captureScreenCursor;
> 
> This property does not seems to exists:
> https://developer.apple.com/library/mac/documentation/AVFoundation/Reference/AVCaptureScreenInput_Class/Reference/Reference.html

It is not referenced in the documentation however it is mentionned in this changelog https://developer.apple.com/library/Mac/releasenotes/General/APIDiffsMacOSX10_8/AVFoundation.html and it does work.
Comment 4 Andoni Morales 2013-11-06 00:00:30 UTC
Another undocumented feature :)
It's still not available for 10.7, so we also need to cover this scenario
Comment 5 Matthieu Bouron 2013-11-06 14:04:54 UTC
Created attachment 259080 [details] [review]
avfvideosrc: support screen capture on OSX
Comment 6 Andoni Morales 2013-11-07 14:34:08 UTC
commit 66334591cc29d3526400f9a8473ce9a11ed37d8e
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Mon Nov 4 11:14:35 2013 +0000

    avfvideosrc: support screen capture on OSX
    
    https://bugzilla.gnome.org/show_bug.cgi?id=711432